search

itm / wsn-device-drivers

Drivers for Wireless Sensor Network Devices
Other
6 stars 4 forks source link

librxtxSerial.so for PowerPc #135

Closed gvz closed 11 years ago

gvz commented 11 years ago

Hi,

I added the librxtxSerial.so for PowerPC, this makes it possible to use PowerPcs as iwsn-servers.

Regards

Georg von Zengen

danbim commented 11 years ago

Thanks!!!

danbim commented 11 years ago

Sorry, I've just had a second look on this pull request and noticed that it was done for the master branch. So, unfortunately I'll have to revert this commit from master branch. Reason is that we're (mostly) using the git flow branching model (http://nvie.com/posts/a-successful-git-branching-model/) and with this the master branch only contains releases. Every development is done in the develop branch.

Can you please give me that pull request again for the develop branch? Also, please have a look at the JarUtil class (https://github.com/itm/wsn-device-drivers/blob/develop/core/src/main/java/de/uniluebeck/itm/wsn/drivers/core/util/JarUtil.java) which is responsible for loading the correct library on the various platforms. I assume that your PPC library will have to be registered there to be correctly loaded at runtime.

danbim commented 11 years ago

Hmm. Forget about the revert. Seems that I've not taken care enough and so I've already merged more than one pull request into master. I'll merge the commits from master into develop so at least develop also contains the changes in master.

But, regarding the JarUtil class it would still be good if you add and test :-).

gvz commented 11 years ago

Hi,

Thank you for merging it, I will do the next requests to development.

I do not think there is something to be done in the JarUnit. There is no extra code for all the other platforms too.

Am 2013-04-24 14:48, schrieb Daniel Bimschas:

Hmm. Forget about the revert. Seems that I've not taken care enough and so I've already merged more than one pull request into master. I'll merge the commits from master into develop so at least develop also contains the changes in master.

But, regarding the JarUtil class it would still be good if you add and test :-).

Reply to this email directly or view it on GitHub [1].

Links:

[1] https://github.com/itm/wsn-device-drivers/pull/135#issuecomment-16924046

danbim commented 11 years ago

Argh.... you're right! In my hurry I mixed up arch and OS :-)