search

itm / wsn-device-drivers

Drivers for Wireless Sensor Network Devices
Other
6 stars 4 forks source link

https://github.com/danbim #34

Closed theodori closed 13 years ago

theodori commented 13 years ago

sunspot device drivers and resources (sunspot sdk)

danbim commented 13 years ago

Hi,

I'm very happy to see this pull request :). But I have one little question for now: why does the SDK need to be in there? Is there no such thing as a Maven dependency available or could we not build one and deploy it on our own Maven repository? I think this doesn't really belong into this project.

Regards, Daniel

theodori commented 13 years ago

Hi Daniel, there is no maven dependency for the sunspot sdks . maybe it would be useful to be placed in a separate module and exposed to a repo.. and then used as a dependency But the code is really depended on the sdk (this version and needs a path to it) and to a couple of things more in the tr.iwsn that I will post it as issues.

Thank you very much

kind regards, Evangelos

Στις 7/6/2011 10:27 μμ, ο/η danbim έγραψε:

Hi,

I'm very happy to see this pull request :). But I have one little question for now: why does the SDK need to be in there? Is there no such thing as a Maven dependency available or could we not build one and deploy it on our own Maven repository? I think this doesn't really belong into this project.

Regards, Daniel

mlegenhausen commented 13 years ago

Maybe we can clean up the request a little bit. I see documentation that should not be commited to the repository. When needed add it to the github sites.

I will take a closer look to the request tomorrow.

mlegenhausen commented 13 years ago

There is a big problem in this pull request. You are using the old drivers from testbed-runtime. These drivers are not supported in this repository. Maybe you should pull this commit to testbed-runtime!

mlegenhausen commented 13 years ago

I think we can close this request? I would recommend to use the develop branch instead of the master branch. Both, for development and the next pull request.

danbim commented 13 years ago

Evangelos,

what do you say about new driver/old driver architecture?

theodori commented 13 years ago

Daniel, I am trying to convert the sunspot driver in order to comply with a new architecture. I think I will come up with a new pull request soon.

Kind regards, Evangelos

Στις 9/6/2011 11:39 πμ, ο/η danbim έγραψε:

Evangelos,

what do you say about new driver/old driver architecture?

danbim commented 13 years ago

Great! Thank you!