itm4n / PrivescCheck

Privilege Escalation Enumeration Script for Windows
BSD 3-Clause "New" or "Revised" License
2.91k stars 422 forks source link

Credential Guard #49

Closed 0xJs closed 1 year ago

0xJs commented 1 year ago

Hi itm4n,

Just wanted to let you know, there might be something wrong with the credential guard logic or i'm missing something. Invoke-CredentialGuardCheck might require a little update. Get-WindowsVersion also doesn't exist so it still returns "Credential Guard is not supported on this OS"

On my Windows 11 machine Credential Guard was running (by default on Windows 11) but it wasn't configured.

Check configuration returned false:

"CredentialGuard" -match ((Get-ComputerInfo).DeviceGuardSecurityServicesConfigured)

Check running returned true:

"CredentialGuard" -match ((Get-ComputerInfo).DeviceGuardSecurityServicesRunning)

Please close it if you think it isn't an issue, just wanted to let you know and help improve your awesome script!

itm4n commented 1 year ago

Hello,

Thanks for reporting this. I'm already aware of this issue, and it's already fixed. I have several pending changes and updates that I need to push to the main branch.

On Windows 11, Credential Guard is enabled by default without any configuration if all the software and hardware requirements are met. This is why you see it as "running" but not as "configured".

0xJs commented 1 year ago

Awesome thanks!

itm4n commented 1 year ago

Fixed with commit e1fa7f802c7509ef1512493ae98c834147b00216