itm4n / PrivescCheck

Privilege Escalation Enumeration Script for Windows
BSD 3-Clause "New" or "Revised" License
2.79k stars 416 forks source link

Get-HotFixList misses updates #52

Closed v-p-b closed 1 month ago

v-p-b commented 5 months ago

I ran the script on a Server 2022 system with KB5033118 installed. Since this update apparently doesn't create a registry key in the expected format Get-HotFixList misses this update.

As far as I can tell parsing update information from the registry is an unsupported hack, so I think it would make sense in the long term if the script parsed both the registry and Get-HotFix, and warn the user if Get-Hotfix shows an update not collected from the registry.

itm4n commented 5 months ago

You are making a good point. I already noticed this discrepancy between the official Get-HotFix and the data present in the registry.

Your proposition makes sense, but I might also just get rid of the custom registry parsing altogether.

Thanks for taking the time to report the issue. I'll see what I can do.

itm4n commented 4 months ago

Should be fixed with commit 373014d6a7fb8a90e4599fab196366e3d8563539.