search

itmammoth / rails_sortable

Easy drag & drop sorting with persisting the arranged order for rails
MIT License
142 stars 37 forks source link

Default axis #36

Closed sebastienwozny closed 5 years ago

sebastienwozny commented 5 years ago

Hi @itmammoth and thanks for the gem! Why have you specified the default axis "y" in your gem ?

It make more sens to me to keep the widget default parameter. (Made me crazy for twenty minutes before I understand)

https://github.com/itmammoth/rails_sortable/blob/b4b273ba72d05d96a76a4bc1d5e9f2e6ce895ef3/vendor/assets/javascripts/plugin.js#L6

https://api.jqueryui.com/sortable/#option-axis

axis 
Type: String
Default: false

xoxo

itmammoth commented 5 years ago

Thanks @sebastienwozny You have a point. The default parameters should have been more respected. I will make a change to it later.