Heading text checker ignores aria-labels on links

itmaybejj / editoria11y-wp

WordPress wrapper for Editoria11y

GNU General Public License v2.0

6 stars 2 forks source link

Heading text checker ignores aria-labels on links #10

Closed cbirdsong closed 9 months ago

cbirdsong commented 1 year ago

The heading text checker is flagging the following as blank:

<h1 class="header-logo">
  <a href="/" aria-label="Site Name">
    <svg width="303" height="158" viewBox="0 0 303 158" fill="currentColor" xmlns="http://www.w3.org/2000/svg">
       <!-- excluded for brevity -->
    </svg>
  </a>
</h1>

Chrome dev tools and VoiceOver both pick up the aria label as the heading's text.

itmaybejj commented 1 year ago

I honestly may not get to look into this until summer, but in the interim -- the plugin works best when constrained to user-editable content. I recommend using one of constraints in the site config; either works:

Check content in these containers: main (or whatever selects the main content region in your theme)
Exclude these elements from checks: .header-logo

cbirdsong commented 1 year ago

Yeah, that makes sense – I had it on main but had to move it to .site-wrapper because of #8.

itmaybejj commented 1 year ago

Yep; go for the exclusion method then.

Luckily #8 will be a quick fix. Hopefully within the next week or so.

itmaybejj commented 9 months ago

Fixed in 1.0.13!