itmaybejj / editoria11y-wp

WordPress wrapper for Editoria11y
GNU General Public License v2.0
6 stars 2 forks source link

Is this intended behavior for external links? #5

Closed cbirdsong closed 1 year ago

cbirdsong commented 1 year ago

On a client's site, the external link check blocks out the entire paragraph in the editor:

https://user-images.githubusercontent.com/1672206/233201154-d65fc765-eb78-45c5-89d1-0c2c4b91e5ac.mp4

Is this how it's supposed to work?

itmaybejj commented 1 year ago

Oh dear. That should be a fine hairline around the block, with the issue title at the bottom right.

I will see if I can replicate and fix this tomorrow. I'm assuming it has something to do with positioning or is z indexing in the block.

For now you should be able to disable the live check altogether on that site, unless that setting is one of the ones not saving changes.

itmaybejj commented 1 year ago

I haven't reproduced this yet but I've thrown a pile of CSS against the usual suspects in 1.0.9...please do holler if you are able to test.

If it isn't fixed, I would dearly love a screenshot of what your Web inspector is showing for the computed CSS for the ::after on that block.

cbirdsong commented 1 year ago

This looks correct now, though it is a little odd in a block with multiple links:

CleanShot 2023-04-20 at 08 39 39

Going to make a separate issue about that.