search

itoffshore / alpine-linux-scripts

Alpine Linux Setup Scripts
GNU General Public License v2.0
46 stars 13 forks source link

please check scripts with ShellCheck #5

Closed speculatrix closed 3 years ago

speculatrix commented 3 years ago

Running ShellCheck against https://github.com/itoffshore/alpine-linux-scripts/blob/master/setup-disk revealed this:

line 810:
                            until [ $answer -ge 1 2>/dev/null ] && [ $answer -le 7 2>/dev/null ]; do
                                                        ^-- SC1009: The mentioned syntax error was in this until loop.
                                                              ^-- SC1073: Couldn't parse this test expression. Fix to allow more checks.
                                                                              ^-- SC1072: Expected test to end here (don't wrap commands in []/[[]]). Fix any mentioned problems and try again.

For more information:
  https://www.shellcheck.net/wiki/SC1072 -- Expected test to end here (don't ...
  https://www.shellcheck.net/wiki/SC1073 -- Couldn't parse this test expressi...
  https://www.shellcheck.net/wiki/SC1009 -- The mentioned syntax error was in...
itoffshore commented 3 years ago

many thanks ;o)