search

itom-project / itom

itom core repository
https://itom-project.github.io/
Other
14 stars 5 forks source link

ITOM Version #149

Open photoniker opened 1 year ago

photoniker commented 1 year ago

Creating some installer for a customer of ours,

i found the ITOM _VERSION_STRING was reverse-regexed from some global.h file.

A better approach ,and likely more standard, would be to do it as in

https://cmake.org/cmake/help/latest/guide/tutorial/index.html#adding-a-version-number-and-configured-header-file

Also some git info could easily be retrieved and placed in that version/global header to be available to more plugins at cpp compiletime.

‌

Are you interested?

May i implement this?

magro11 commented 1 year ago

M. Gronle

It would be great if you could implement a proposal for this. Since we have now CMake 3.1 as minimal requirement, the project( VERSION…) tag is now available.

Git information are currently fetched via a python script, called by CMake. They are placed in the version.h, that is also exposed to the SDK and then accessible to plugins (however: do plugins really need git information of itom?? Usually plugins should mainly rely on the addin-interface-version number and maybe the designerplugin-interface version number, since they define the binary compatibility). The itom version is currently exposed to plugins / designerplugins by the itom_sdk.h file, which is the major header file to properly identify the itom SDK.

[Edit](https://bitbucket.org/itom/itom/issues/149/itom-version#edit)
Pin to top
Mark as spam
Delete
2020-10-07

Bernd Bertschinger

changed version to [4.2.1](https://bitbucket.org/itom/itom/issues?version=4.2.1)
assigned issue to
Bernd Bertschinger

Ticket still open. Changed version to 4.2.1 ans assigned myself to the task.

Pin to top
Mark as spam
2022-07-08

Bernd Bertschinger

marked as [trivial](https://bitbucket.org/itom/itom/issues?priority=trivial)