search

itom-project / itom

itom core repository
https://itom-project.github.io/
Other
13 stars 5 forks source link

QDropEvent methods #274

Closed twip-os closed 5 months ago

twip-os commented 6 months ago

In commit 3f85bb7cf53521847a694dcdb498b9c4fa9b4ff8 changed some calls on QDropEvent to prevent deprecation warnings, probably with QT6. But the new names throw errors with QT5.15.2. Do we need a switch for the QT version here or is the deprecation warning acceptable?

Cheers Thomas

photoniker commented 6 months ago

Since that still work with qt6.6.0 you dont`t need to switch qt6 version. There are some more deprecation warning which In started to fix in a branch.

twip-os commented 6 months ago

So we will revert the changes in the mentioned commit?

photoniker commented 6 months ago

Yes we can add a Version switch for qt5/6. But In don`t get an Error using qt5.15

twip-os commented 5 months ago

This is strange. The documentation states that "buttons", "modifiers" and "positions" are only there since 6.0.

magro11 commented 5 months ago

@twip-os : which kind of errors did you mean? Compiler errors or anything else?

twip-os commented 5 months ago

Yes, compiler error caused by missing members:

5>C:\consignoDevelop\sources\itom\Qitom\widgets\scriptEditorWidget.cpp(1009,28): error C2039: 'position': is not a member of 'QDropEvent' 5>C:\consignoDevelop\3rdParty\Qt5.15.2\5.15.2\msvc2019_64\include\QtWidgets/qwidget.h(87): message : see declaration of 'QDropEvent' 5>C:\consignoDevelop\sources\itom\Qitom\widgets\scriptEditorWidget.cpp(1012,28): error C2039: 'buttons': is not a member of 'QDropEvent' 5>C:\consignoDevelop\3rdParty\Qt5.15.2\5.15.2\msvc2019_64\include\QtWidgets/qwidget.h(87): message : see declaration of 'QDropEvent' 5>C:\consignoDevelop\sources\itom\Qitom\widgets\scriptEditorWidget.cpp(1013,28): error C2039: 'modifiers': is not a member of 'QDropEvent' 5>C:\consignoDevelop\3rdParty\Qt5.15.2\5.15.2\msvc2019_64\include\QtWidgets/qwidget.h(87): message : see declaration of 'QDropEvent'