itom-project / itom

itom core repository
https://itom-project.github.io/
Other
13 stars 5 forks source link

Applied code checks #284

Closed photoniker closed 2 months ago

photoniker commented 2 months ago

I have applied checks and fixes onto the source code using pre_commit hooks:

photoniker commented 2 months ago

For python unittest I see such fails:

Traceback (most recent call last): File "c:\itom\sources\itom\python_unittests\dataobject_np_conversion.py", line 24, in ... test_continuousDataObject2NpArray self.assertIs(b1.base, a) AssertionError: (dataObject('uint8', [2 x 3 x 3], continuous: 1, owndata: 1), <capsule object NULL at ... 0x000002D908301B00>) is not dataObject('uint8', [2 x 3 x 3], continuous: 1, owndata: 1)`

Traceback (most recent call last): File "c:\itom\sources\itom\python_unittests\itom_jedilib.py", line 229, in test_help_notypehints self.assertEqual(len(h), 0) AssertionError: 1 != 0`

@magro11 Can you run and check that unitttests?

BBertschinger commented 2 months ago

Do we have a documentation on how to apply our pre-commit hooks?

photoniker commented 2 months ago

@BBertschinger see into the README of https://github.com/itom-project image