search

itom-project / itom

itom core repository
https://itom-project.github.io/
Other
13 stars 5 forks source link

Alter gtest to 1.12.1 #289

Closed magro11 closed 1 month ago

magro11 commented 2 months ago

In order to remove some CMake and compiler warnings, the gtest sources have been altered to version 1.12.1. This is the last version supporting C++11. gtest 1.13 / 1.14 require C++14. This might be ok, too, however the modifications seem to be not really relevant. Tested with VS2017 / Qt5.12 (single projects) and VS2022 / Qt6.4 (submodule itom-project structure)

photoniker commented 2 months ago

image Should the cmake variable gest_force_shared_crt be set to ON per default?

photoniker commented 2 months ago

image Why are there not tests in unittest_qpropertyeditor?

magro11 commented 2 months ago

I have no idea if there is a robust way to set gtest_force_shared_crt to ON per default, probably is should be possible, yes.

magro11 commented 2 months ago

Update: gtest_force_shared_crt is now automatically forced to ON.

From my side: ready to merge!