search

itomig-de / itomig-webhook-integration

3 stars 2 forks source link

ActionWebRequest datamodel #13

Closed Hipska closed 3 years ago

Hipska commented 4 years ago

Why is the class ActionWebRequest defined in php code and not in the datamodel.xml file? It makes it harder to change or extend this class. If it would be changed, the parent for ActionWebhookNotification could then also be set more correctly.

Molkobain commented 4 years ago

Hello @Hipska ,

We are currently working on an implementation of the webhook actions directly in iTop (based on @larhip 's extension). Do you examples of what you would do if those classes were in the XML instead of being in PHP directly?

Guillaume

Hipska commented 4 years ago

It’s a datamodel item, so it should be in the xml anyway. So if you would want to extend or modify it, it would be possible with the xml. Also adding fields or changing display order should be possible.

Hipska commented 4 years ago

It could be done by the means of an intermediate php class _ActionWebRequest to be able to keep the methods in php file.

Molkobain commented 4 years ago

Exactly, thanks for your feedback.

Hipska commented 3 years ago

Can be closed as this will get there in Comodo's implementation.