search

itplr-kosit / validator-configuration-xrechnung

Configuration for validating documents against the German XRechnung standard using the KoSIT validation tool
https://xeinkauf.de/xrechnung/
Apache License 2.0
65 stars 17 forks source link

Validation of UBL Credit Notes for XRechnung 2.0.0 fails #45

Closed webwart-bln closed 3 years ago

webwart-bln commented 3 years ago

Hello,

I think that the latest released version of the schematron rules for the XRechnung version 2.0.0 did not update the expected cbc:CustomizationID value for credit notes. Version 1.4.0 of the rules look like this:

        <!--ASSERT -->
      <xsl:choose>
         <xsl:when test="cbc:CustomizationID = 'urn:cen.eu:en16931:2017#compliant#urn:xoev-de:kosit:standard:xrechnung_1.2'"/>
         <xsl:otherwise>
            <svrl:failed-assert xmlns:svrl="http://purl.oclc.org/dsdl/svrl"
                                test="cbc:CustomizationID = 'urn:cen.eu:en16931:2017#compliant#urn:xoev-de:kosit:standard:xrechnung_1.2'">
               <xsl:attribute name="id">BR-DE-21</xsl:attribute>
               <xsl:attribute name="flag">warning</xsl:attribute>
               <xsl:attribute name="location">
                  <xsl:apply-templates select="." mode="schematron-select-full-path"/>
               </xsl:attribute>
               <svrl:text>[BR-DE-21] Das Element "Specification identifier" (BT-24) soll syntaktisch der Kennung des Standards XRechnung entsprechen.</svrl:text>
            </svrl:failed-assert>
         </xsl:otherwise>
      </xsl:choose>

The invoice test looks like this:

 <xsl:when test="cbc:CustomizationID = 'urn:cen.eu:en16931:2017#compliant#urn:xoev-de:kosit:standard:xrechnung_2.0' or cbc:CustomizationID = 'urn:cen.eu:en16931:2017#compliant#urn:xoev-de:kosit:standard:xrechnung_2.0#conformant#urn:xoev-de:kosit:extension:xrechnung_2.0'"/>
         <xsl:otherwise>
            <svrl:failed-assert xmlns:svrl="http://purl.oclc.org/dsdl/svrl"
                                test="cbc:CustomizationID = 'urn:cen.eu:en16931:2017#compliant#urn:xoev-de:kosit:standard:xrechnung_2.0' or cbc:CustomizationID = 'urn:cen.eu:en16931:2017#compliant#urn:xoev-de:kosit:standard:xrechnung_2.0#conformant#urn:xoev-de:kosit:extension:xrechnung_2.0'">

It would be amazing if a fixed version could be made public soon. We are currently updating our generation of XRechnung files to 2.0.0 and are relying on the validator to be sure that we are good to go ;-)

Greetings and best wishes from Berlin Heiko

webwart-bln commented 3 years ago

Btw: It seems to be fixed with this commit:

https://github.com/itplr-kosit/xrechnung-schematron/commit/cd1ce874c15f3778a5df664e80dd480047b8a13d#diff-b0f5b139511878dc79f0d7608ec2a4d85be8ebe29a364b75d7b9fe27fa1aa262

rkottmann commented 3 years ago

Thx for reporting. Indeed it with already fixed.

webwart-bln commented 3 years ago

Do you know when a new version is going to be released?

rkottmann commented 3 years ago

latest end of this month