itplr-kosit / validator-configuration-xrechnung

Configuration for validating documents against the German XRechnung standard using the KoSIT validation tool
https://xeinkauf.de/xrechnung/
Apache License 2.0
65 stars 17 forks source link

Release 31.07.2021 readme does not fit, download liks are misleadeing #69

Closed ubabap closed 2 years ago

ubabap commented 3 years ago

Hello together,

could you please add all Links, taht are needed for Release 31.07.21 and adapt the readme for this release? There are 3 Links , whre one is called Code, but does not have code. In the readme is a Link to downlowad version 1.4.1 , but in the text it says, version 1.4.2 is needed... Couldn't you just pack everything together in one zip?

phax commented 3 years ago

Are you looking for https://github.com/itplr-kosit/validator-configuration-xrechnung/releases/tag/release-2021-07-31 ?

ubabap commented 3 years ago

No. I am asking to improve the information at the mentioned page.

It is not convenient or clear. I.e.: There is no link to a validation tool version 1.4.2 and in the actual version of xoev https://www.xoev.de/xrechnung-16828#DL , the bundle to use this year is from 12/20 and it coantins version 1.4.1 .

Also there are 3 Assets https://github.com/itplr-kosit/validator-configuration-xrechnung/releases/download/release-2021-07-31/validator-configuration-xrechnung_2.1.1_2021-07-31.zip https://github.com/itplr-kosit/validator-configuration-xrechnung/archive/refs/tags/release-2021-07-31.zip (named source code??) https://github.com/itplr-kosit/validator-configuration-xrechnung/archive/refs/tags/release-2021-07-31.tar.gz (also name source code)

The first one only contain some style sheets(transformations) etc.. Where is the source code for the mentioned version 1.4.2 of the validator itself? (The future release download on xoev page doen not work, tahe actual contains 1.4.1 )

Could the contained readme.md be adapted to mention the right links according to the changelog and not the old ones? In the readme . README.md the text says

download validator

curl -L 'https://github.com/itplr-kosit/validator/releases/download/v1.4.1/validationtool-1.4.1.zip' --output validator.zip

download configuration

curl -L 'https://github.com/itplr-kosit/validator-configuration-xrechnung/releases/download/release-2020-12-31/validator-configuration-xrechnung_2.0.1_2020-12-31.zip' --output validator-configuration.zip

download a test document

curl -L 'https://raw.githubusercontent.com/itplr-kosit/xrechnung-testsuite/master/src/test/business-cases/standard/01.01a-INVOICE_ubl.xml' --output ubl.xml ...

in the changelog:

Changed

Off topic: i am German and i see mixed langauge issues here. What is appropriate?

ubabap commented 3 years ago

If more are wondering about the inconsistencies in information: this source bundle 2.1.1, valid from 1.2.2022 , does contain the 1.4.2. This zip also contains a configuration.zip that has the same name as the one mentioned here. Is it the same? -> then all needed is being found i that zip and this is the only link needed.

Edit: It would be good, to just adapt the readme, to have the actual files and versions in the examples and it would be great to add a link to bundle 2.1.1, valid from 1.2.2022 , or the homepage xoev.de, where a complete set of a relaese is provided.

I want to "delete" the following part, as it is not appropriatly adressed here. ( It is for one user of the package, not for GIt community) _According to xoev download version 2.0.1 has to be used till 31.1.2022.

Here we have some files that are said to be used (or tested?) with 1.4.2 but already for oktober 2021 . As it is already september, there is not so much time left to change the setups and maybe implement changes needed.

What is the complete set of files , that needs to be used, now?
Or very concrete: can i run the 1.4.1 jar file with the scenarios.xml file of the release mentioned here? ( does the .jar need more files, that need to be in a certain path structure? Looking into the scenarios.xml shows: the relative paths and other files are needed in the exact structure provided. If following the instructions that will be the case, but i think it is worth mentioning in a description as well.

Is it really too hard to just pack everything together in one zip, even if some sources do have other roots? -> see above, i guess all needed is in the xoev zip. Or at least provide only the needed links with a clear setup and usage description (Just adapt the names , e.g. of the jar file to be used and mention not to change the location after unzipping the configuration in the readme. Also comment if the standaloen version of the 1.4.2 jar can be used, or which of the 3 available versions are to be used. I guess standalone reduces conflicts with java version )?

The most confusing topic is still, why does xoev say this version is not actually to be used before 2/2022 but we(or better who ) shall do ?_

Best regards

Ulrich Becker

bdewein commented 2 years ago

we consider this fixed, please re-open if this is still an issue