Closed trojikman closed 3 years ago
Impacted versions: discovered in 11.0 while using the module mail_to (mail_base is a dependency) Source: https://github.com/itpp-labs/mail-addons/tree/11.0/mail_base
mail_to
mail_base
How to reproduce:
Error: TypeError: channel is undefined
http://localhost/mail_base/static/lib/base.js:433 Traceback: chat_manager.get_channel_cache@http://localhost/mail_base/static/lib/base.js:433:9 chat_manager.get_messages@http://localhost/mail_base/static/lib/base.js:979:42 open_chat/<@http://localhost/mail/static/src/js/window_manager.js:106:37 then/</</<@http://localhost/web/static/lib/jquery/jquery.js:3276:89 fire@http://localhost/web/static/lib/jquery/jquery.js:3119:58 add@http://localhost/web/static/lib/jquery/jquery.js:3165:53 then/</<@http://localhost/web/static/lib/jquery/jquery.js:3275:77 each@http://localhost/web/static/lib/jquery/jquery.js:383:58 then/<@http://localhost/web/static/lib/jquery/jquery.js:3272:56 Deferred@http://localhost/web/static/lib/jquery/jquery.js:3332:30 then@http://localhost/web/static/lib/jquery/jquery.js:3271:55 open_chat@http://localhost/mail/static/src/js/window_manager.js:104:14 trigger@http://localhost/web/static/src/js/core/mixins.js:226:31 trigger@http://localhost/web/static/src/js/core/mixins.js:330:42 add_channel@http://localhost/mail/static/src/js/chat_manager.js:285:30 _.forEach@http://localhost/web/static/lib/underscore/underscore.js:145:17 _onMailClientAction/<@http://localhost/mail/static/src/js/chat_manager.js:677:15 _.forEach@http://localhost/web/static/lib/underscore/underscore.js:150:17 _onMailClientAction@http://localhost/mail/static/src/js/chat_manager.js:676:11 then/</</<@http://localhost/web/static/lib/jquery/jquery.js:3276:89 fire@http://localhost/web/static/lib/jquery/jquery.js:3119:58 fireWith@http://localhost/web/static/lib/jquery/jquery.js:3231:53 Deferred/</deferred[tuple[0]]@http://localhost/web/static/lib/jquery/jquery.js:3321:62 fire@http://localhost/web/static/lib/jquery/jquery.js:3119:58 fireWith@http://localhost/web/static/lib/jquery/jquery.js:3231:53 Deferred/</deferred[tuple[0]]@http://localhost/web/static/lib/jquery/jquery.js:3321:62 fire@http://localhost/web/static/lib/jquery/jquery.js:3119:58 fireWith@http://localhost/web/static/lib/jquery/jquery.js:3231:53 then/</</<@http://localhost/web/static/lib/jquery/jquery.js:3283:104 fire@http://localhost/web/static/lib/jquery/jquery.js:3119:58 fireWith@http://localhost/web/static/lib/jquery/jquery.js:3231:53 then/</</<@http://localhost/web/static/lib/jquery/jquery.js:3283:104 fire@http://localhost/web/static/lib/jquery/jquery.js:3119:58 fireWith@http://localhost/web/static/lib/jquery/jquery.js:3231:53 done@http://localhost/web/static/lib/jquery/jquery.js:9275:42 callback@http://localhost/web/static/lib/jquery/jquery.js:9685:65
Expected behavior: don't get error
Impacted versions: discovered in 11.0 while using the module
mail_to
(mail_base
is a dependency) Source: https://github.com/itpp-labs/mail-addons/tree/11.0/mail_baseHow to reproduce:
http://localhost/mail_base/static/lib/base.js:433 Traceback: chat_manager.get_channel_cache@http://localhost/mail_base/static/lib/base.js:433:9 chat_manager.get_messages@http://localhost/mail_base/static/lib/base.js:979:42 open_chat/<@http://localhost/mail/static/src/js/window_manager.js:106:37 then/</</<@http://localhost/web/static/lib/jquery/jquery.js:3276:89 fire@http://localhost/web/static/lib/jquery/jquery.js:3119:58 add@http://localhost/web/static/lib/jquery/jquery.js:3165:53 then/</<@http://localhost/web/static/lib/jquery/jquery.js:3275:77 each@http://localhost/web/static/lib/jquery/jquery.js:383:58 then/<@http://localhost/web/static/lib/jquery/jquery.js:3272:56 Deferred@http://localhost/web/static/lib/jquery/jquery.js:3332:30 then@http://localhost/web/static/lib/jquery/jquery.js:3271:55 open_chat@http://localhost/mail/static/src/js/window_manager.js:104:14 trigger@http://localhost/web/static/src/js/core/mixins.js:226:31 trigger@http://localhost/web/static/src/js/core/mixins.js:330:42 add_channel@http://localhost/mail/static/src/js/chat_manager.js:285:30 _.forEach@http://localhost/web/static/lib/underscore/underscore.js:145:17 _onMailClientAction/<@http://localhost/mail/static/src/js/chat_manager.js:677:15 _.forEach@http://localhost/web/static/lib/underscore/underscore.js:150:17 _onMailClientAction@http://localhost/mail/static/src/js/chat_manager.js:676:11 then/</</<@http://localhost/web/static/lib/jquery/jquery.js:3276:89 fire@http://localhost/web/static/lib/jquery/jquery.js:3119:58 fireWith@http://localhost/web/static/lib/jquery/jquery.js:3231:53 Deferred/</deferred[tuple[0]]@http://localhost/web/static/lib/jquery/jquery.js:3321:62 fire@http://localhost/web/static/lib/jquery/jquery.js:3119:58 fireWith@http://localhost/web/static/lib/jquery/jquery.js:3231:53 Deferred/</deferred[tuple[0]]@http://localhost/web/static/lib/jquery/jquery.js:3321:62 fire@http://localhost/web/static/lib/jquery/jquery.js:3119:58 fireWith@http://localhost/web/static/lib/jquery/jquery.js:3231:53 then/</</<@http://localhost/web/static/lib/jquery/jquery.js:3283:104 fire@http://localhost/web/static/lib/jquery/jquery.js:3119:58 fireWith@http://localhost/web/static/lib/jquery/jquery.js:3231:53 then/</</<@http://localhost/web/static/lib/jquery/jquery.js:3283:104 fire@http://localhost/web/static/lib/jquery/jquery.js:3119:58 fireWith@http://localhost/web/static/lib/jquery/jquery.js:3231:53 done@http://localhost/web/static/lib/jquery/jquery.js:9275:42 callback@http://localhost/web/static/lib/jquery/jquery.js:9685:65