Open alex2grad opened 2 years ago
Just removing will break the mail_base module...
No, removing it breaks nothing. I checked. Why do you think it breaks mail_base?
If you want to remove mail_base's event you should provide the selector and event arguments.
I mean that is was added by a purpose. As I remember, it's needed because we copy-pasted code from original mail module and without .off() we'd have duplicates fo the handler. We can take a look, if you make a PR
Need to remove bus.off('notification'); from mail_base/static/lib/base.js
Calling .off() with no arguments removes all handlers attached to the bus