search

itpresidents / thesis-archive-2020

10 stars 1 forks source link

Article page Desktop styling fixes #37

Closed ilanabonder closed 4 years ago

ilanabonder commented 4 years ago

GRID

The grid is not being used properly: Image hero = 100% full page Texts = use 8 columns of the 12 column grid — which I think is good now but Images and student/portfolio/advisor component = use 10 columns of the 12 column grid (please fix)

You can see that on image below:

Screen Shot 2020-04-15 at 8 31 03 PM

TEXT

Tags The tags should be colored: #828282

Summary @media (min-width: 768px) typography.scss:40 .summary {
 font-size: 1.5rem;
 font-weight: 300;

Body Text .body1 { font-size: 1.25rem; line-height: 1.9rem;

oveddan commented 4 years ago

@ilanabonder regarding hero image being 100% page size - do we not want to cap it? What if they upload a wierdly shaped image?

Text currently uses 8 columns and images are 10 columns - except for the hero image. Maybe we should change the actual grid size? What are the grid column widths?

oveddan commented 4 years ago

Fixed d11169c Can you please check @ilanabonder ?

ilanabonder commented 4 years ago

yes looks great <3