search

itpresidents / thesis-archive-2020

10 stars 1 forks source link

Card sizes dont match those in figma #63

Closed oveddan closed 4 years ago

oveddan commented 4 years ago

If we go to the DesignSystem tab of Figma, we can see there are two sizes for the cards, one for desktop and one for mobile:

Screen Shot 2020-04-26 at 10 33 10 PM

On desktop

Card outer size should be, 212x395:

Screen Shot 2020-04-26 at 10 33 26 PM

Card image size should be 212x300:

Screen Shot 2020-04-26 at 10 34 20 PM

On Mobile

Card Size outer should be 175.5x327

Screen Shot 2020-04-26 at 10 37 55 PM

Card inner size 175.5x248.35

Screen Shot 2020-04-26 at 10 36 50 PM
oveddan commented 4 years ago

Looks like this was fixed in #64 !

EonYang commented 4 years ago

To be clear, I wrote the code and I know it's still not 100% aligned, but it's intentional.

I added a small factor that the size of the window will slightly affect the actual card size.

I don't know if it's the most optimal solution, so further discussions are welcome~

EonYang commented 4 years ago

Fixed~~~