Open alexqu0822 opened 3 years ago
itsSinba
commented
3 years ago Hey Sinba! A good thing is that github is not blocked.
zhCN.lua is modified. I made a list file 'reflect.txt' that reflect between lables of HUD stat and text of setting. It maybe help4 for other translators.
Hey Alex! Happy to hear that. We should talk on here from now on then! I saw the reflect, very well put, thanks! I can't see any changes in zhCN.lua for some reason ? The file is exactly as I left it
alexqu0822
commented
3 years ago Yes Sinba, love git haha!
https://github.com/alexqu0822/SinStats/commit/c059a91479082aa31fdacbd4c0b9086a8c9f8438 Here is changes compared to v3.5 in my forked copy.
I noticed that penetration's tip is wrong. Armor and spell pene make player ignore armor or res of certern value, not by percentage. I also made some change to Sinstats.lua and SinstatsConfig.lua because these embeded fonts donot support zh and kr. not sure for other langs aside from eng. |cff880303[有爱]|r is my tag in toc files, not translation. FYI
itsSinba
commented
3 years ago Yes Sinba, love git haha!
alexqu0822@c059a91 Here is changes compared to v3.5 in my forked copy.
I noticed that penetration's tip is wrong. Armor and spell pene make player ignore armor or res of certern value, not by percentage. I also made some change to Sinstats.lua and SinstatsConfig.lua because these embeded fonts donot support zh and kr. not sure for other langs aside from eng. |cff880303[有爱]|r is my tag in toc files, not translation. FYI
It looks really good, I appreciate your efforts man. I will implement it soon.. my pc died last night, all I have right now is my phone lol :( I’ll try to get it fixed soon
alexqu0822
commented
3 years ago it's horrible. I cant live without computer :P. Hope not a big problem.
itsSinba
commented
3 years ago Hey Alex. I finally received my new pc :) It was a tough last few days lol I've uploaded a new update with your last changes. Also, I've modified it a bit because I needed the default font to be Arial Narrow and LibStub("LibSharedMedia-3.0"):GetDefault("font") is Fritz Quadrata. I've installed the zhCH locale just to test it. It seems fine, but let me know if there's an issue.
Also, quick question since you seem to know Ace fairly well. Do you have any idea how to add the widget to have the font preview ? like when you click on the dropdown to choose a font, you can see how it looks like. I know that it's part of AceGUI-3.0-SharedMediaWidgets but I've tried so many different things and I never worked...
alexqu0822
commented
3 years ago Yes Sinba, let me have a try. I donot use ACE at all, indeed :P. I think it's tooooo heavy for such a light weight project like wow addon.
code in line 413 'self:SetFont("Fonts\ARIALN.ttf", 16, SinStatsDB.OutlineText)' make it work wrongly in some case. Del it may sovle the problem. Try these files: https://github.com/alexqu0822/SinStats/commit/155cf73ab986fd9e263605a7559cbe733268ac97
Hey Sinba! A good thing is that github is not blocked.
zhCN.lua is modified. I made a list file 'reflect.txt' that reflect between lables of HUD stat and text of setting. It maybe help4 for other translators.