search

itsamayo / esx_tax

GTAV FiveM mod for tax
15 stars 23 forks source link

Added where to Send taxes, and cleaned up #1

Open Modatherrr opened 4 years ago

Modatherrr commented 4 years ago

Just added a user config to where taxes should be sent (For people that have bankerjob for example)

and cleaned up GetUsersForTax() function..

Was thinking for sending message for online players.. but maybe later lol

itsamayo commented 4 years ago

Hey @ModatherM , appreciate the pr, essentially the only change other than the moving of society_police to config is the addition of d, h, m to the one function which doesn't have any requirements?

Modatherrr commented 4 years ago

Hey @ModatherM , appreciate the pr, essentially the only change other than the moving of society_police to config is the addition of d, h, m to the one function which doesn't have any requirements?

Yes, I just moved the society to the config, and removed d, h, m, as i see they are not used in the function, Beside that, I was thinking of converting it to use @ESX-Org/cron to make it daily, it would be more real, as every hour in real life, is a day in game, So it's not real to take taxes every day (in game).

itsamayo commented 4 years ago

Hey @ModatherM , appreciate the pr, essentially the only change other than the moving of society_police to config is the addition of d, h, m to the one function which doesn't have any requirements?

Yes, I just moved the society to the config, and removed d, h, m, as i see they are not used in the function, Beside that, I was thinking of converting it to use @ESX-Org/cron to make it daily, it would be more real, as every hour in real life, is a day in game, So it's not real to take taxes every day (in game).

The reason the timer is set the way it is, is because you get paid a salary every +- 10 minutes (depending on your servers config) so charging tax every hour is not unreasonable.

Modatherrr commented 4 years ago

Hey @ModatherM , appreciate the pr, essentially the only change other than the moving of society_police to config is the addition of d, h, m to the one function which doesn't have any requirements?

Yes, I just moved the society to the config, and removed d, h, m, as i see they are not used in the function, Beside that, I was thinking of converting it to use @ESX-Org/cron to make it daily, it would be more real, as every hour in real life, is a day in game, So it's not real to take taxes every day (in game).

The reason the timer is set the way it is, is because you get paid a salary every +- 10 minutes (depending on your servers config) so charging tax every hour is not unreasonable.

Okay So, it's just moving the society to config and removed d, h, m lol