search

itsanjan / arduino

Automatically exported from code.google.com/p/arduino
Other
0 stars 0 forks source link

LED define conflicts with variables in existing sketches. #651

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
I think we should remove the LED #define, or at least rename it.

Original issue reported on code.google.com by dmel...@gmail.com on 22 Sep 2011 at 8:52

GoogleCodeExporter commented 8 years ago 
Tom suggests LED_L instead.  Or maybe LED_ONBOARD?

Original comment by dmel...@gmail.com on 25 Sep 2011 at 5:36

GoogleCodeExporter commented 8 years ago 
How about ARDUINO_LED; some sort of standard prefix for all the little names 
that it might be nice to have around (ARDUINO_RX, ARDUINO_TX for pins mentioned 
elsewhere.)

Original comment by wes...@gmail.com on 4 Oct 2011 at 10:15

GoogleCodeExporter commented 8 years ago 
Not just "LED". The MISO/MOSI/SCK defines also broke my code - see 
http://forum.jeelabs.net/node/514

Original comment by jc@wippler.nl on 15 Oct 2011 at 9:10

GoogleCodeExporter commented 8 years ago 
I went with LED_BUILTIN.

https://github.com/arduino/Arduino/commit/18838fb44a64e6d2550f79d447360ec46dd832
ce

Original comment by dmel...@gmail.com on 24 Oct 2011 at 8:46