itsapi / pycraft

A Minecraft-inspired game for the terminal
GNU General Public License v2.0
197 stars 21 forks source link

Save compatibility #103

Closed geraintwhite closed 8 years ago

geraintwhite commented 8 years ago

There is no compatibility for saves between miltiplayer and master. Perhaps we should add some, or at least a converter.

olls commented 8 years ago

Or just make it error nicely, as hopefully master-style saves won't be around much longer.

geraintwhite commented 8 years ago

Should we store a save version in the meta and rely on that when opening the meta?

olls commented 8 years ago

Probably

geraintwhite commented 8 years ago

Or perhaps we should go back to checking the whole map on load?

olls commented 8 years ago

No, I don't like that idea. This is not that big of a problem, once we merge multiplayer it will hardly ever happen. I think just recording the save version with the save and checking we can load that version is good enough.

geraintwhite commented 8 years ago

This will actually be quite messy because the message will have to travel from saves.py -> Game -> Server -> LocalInterface. Currently the Game doesn't have a reference to Server, which is the first layer that can directly show an error.

olls commented 8 years ago

Maybe we need a more robust system for sending errors from the back-end to the game loop