search

itsapi / pycraft

A Minecraft-inspired game for the terminal
GNU General Public License v2.0
197 stars 21 forks source link

Network Communication Buggy #39

Closed olls closed 8 years ago

olls commented 9 years ago

It keeps missing bits! Why are we still losing bits of the data? TCP should be reliable!

From Wikipedia:

TCP detects these problems, requests retransmission of lost data, rearranges out-of-order data, and even helps minimize network congestion to reduce the occurrence of the other problems. If the data still remains undelivered, its source is notified of this failure

TCP Definition:

TCP uses error correction and data stream control techniques to ensure that packets to arrive at their intended destinations uncorrupted and in the correct sequence, thereby making the point-to-point connection virtually error-free. Packets are the most fundamental unit of data transmission on TCP/IP networks.

We need to figure out why it's not.

geraintwhite commented 9 years ago

Fixed a lot of the issues f9fff6535cdefdf25b7b67744ee22a74bde04599

geraintwhite commented 8 years ago

Still need to add resending of messages. Not sure if it is very buggy at all any more.