search

itsapi / pycraft

A Minecraft-inspired game for the terminal
GNU General Public License v2.0
197 stars 21 forks source link

Efficiency #61

Closed olls closed 7 years ago

olls commented 8 years ago

I think we should try to keep all the variables under control a bit more, especially in the main loop. We need to ensure we are not needlessly passing large amounts of data around, etc...

olls commented 8 years ago

This will also help us get the code under more control, and probably help us make it more extend-able.

olls commented 8 years ago

The Server class helps with the bigger ones, like map. It keeps them in one place.

Another thing that goes with this is to give a clearer definition of the types/format of the variables, lists, tuples...

olls commented 8 years ago

Also, maybe we shouldn't be running in a while True loop with no delay...

geraintwhite commented 8 years ago

Yes

On Mon, 16 Nov 2015 11:32 Oliver Faircliff notifications@github.com wrote:

Also, maybe we shouldn't be running in a while True loop with no delay...

— Reply to this email directly or view it on GitHub https://github.com/itsapi/pycraft/issues/61#issuecomment-157003352.