search

itsarjunsinh / elder_launcher

A Launcher focused on simplicity and legibility.
MIT License
41 stars 20 forks source link

(feature request) 24h time format option (or based on system settings) #22

Open quxup opened 2 years ago

quxup commented 2 years ago

Hello Arjunsinh Jadeja!

Most launchers pick time format up automatically (and change AM/PM or 24h format themselves). I live in Europe and we're using the 24h format here as well (is is most of the world). Would it be possible to give the user an option to switch between time formats or just make it automatic (based on system settings)?

I think the automatic solution would fit well with the ethos of Elder Launcher (simplicity, which is aimed at elder users).

All the best to you! :)

Jaak

gymka commented 1 year ago

compiled from other fork, it shows 24h. compiled version and source is in my repo https://github.com/gymka/elder_launcher Screenshot_2023-06-17-18-36-06-393_xyz arjunsinh elderlauncher

itsarjunsinh commented 1 year ago

@gymka, the fork's DateTimeProvider is unchanged from the original source code. The time is formatted per device locale, so on a lot of devices this should give the right result. 

  void _updateDateTime() { 
     _time = DateFormat.jm().format(DateTime.now()); 
     _date = DateFormat.MMMMEEEEd().format(DateTime.now()); 
     notifyListeners(); 
   }

However, either due to Flutter, Device or an issue in some other layer the incorrect formatting is received. So for such scenarios there is a case to be made to show it in an Elder Launcher settings page.