Persistent Highlights; Square Cells; Fixing Knapsack

itsdawei / dpvis

A simple and flexible visualization library for dynamic programs

https://dpvis.readthedocs.io/en/latest/

MIT License

4 stars 1 forks source link

Persistent Highlights; Square Cells; Fixing Knapsack #59

Closed itsdawei closed 6 months ago

itsdawei commented 6 months ago

Description

TODO

[x] Persistent Highlights
[x] Make cells squares
[x] Fix Knapsack column labels

Status

[x] I have read the guidelines in CONTRIBUTING.md
[x] I have formatted my code using yapf
[x] I have linted my code with pylint
[x] I have tested my code by running pytest
[x] I have added a one-line description of my change to the changelog in HISTORY.md
[x] This PR is ready to go

aprasad36 commented 6 months ago

Is the heatmap supposed to have these borders? Also, I think the markdown looks pretty weird here.

EDIT: The markdown issue resolves itself when switching from the JOURNAL style to LUX, but honestly we just need to wrap the math in the sidebar somehow.

itsdawei commented 6 months ago

Is the heatmap supposed to have these borders?

No but I also don't know how to fix it. It is because I'm setting the height and width of the heatmap w.r.t. the number of rows and columns we have.