search

itsdax / Runescape-Web-Walker-Engine

A navigation engine for OSRS written for TriBot
https://tribot.org/
Apache License 2.0
81 stars 37 forks source link

Stuck at "Could not grab destination details" #196

Closed BegTribot closed 1 year ago

BegTribot commented 1 year ago

Hi, Issue #188 was closed, but it still happens

[09:27:16] [DaxWalker] Generating path: {"player":{"attack":1,"defence":1,"strength":1,"hitpoints":10,"ranged":1,"prayer":1,"magic":1,"cooking":1,"woodcutting":1,"fletching":1,"fishing":1,"firemaking":1,"crafting":1,"smithing":1,"mining":1,"herblore":1,"agility":1,"thieving":1,"slayer":1,"farming":1,"runecrafting":1,"hunter":1,"construction":1,"setting":[{"key":10,"value":0},{"key":11,"value":0},{"key":17,"value":0},{"key":32,"value":3},{"key":63,"value":0},{"key":68,"value":0},{"key":71,"value":0},{"key":101,"value":4},{"key":111,"value":0},{"key":116,"value":0},{"key":131,"value":0},{"key":144,"value":0},{"key":145,"value":0},{"key":150,"value":0},{"key":165,"value":0},{"key":176,"value":0},{"key":179,"value":0},{"key":212,"value":0},{"key":273,"value":0},{"key":299,"value":0},{"key":302,"value":0},{"key":307,"value":0},{"key":314,"value":0},{"key":335,"value":0},{"key":347,"value":0},{"key":351,"value":0},{"key":365,"value":0},{"key":371,"value":0},{"key":387,"value":0},{"key":399,"value":0},{"key":425,"value":0},{"key":437,"value":0},{"key":440,"value":0},{"key":482,"value":0},{"key":622,"value":0},{"key":655,"value":0},{"key":671,"value":0},{"key":705,"value":0},{"key":794,"value":0},{"key":810,"value":33554432},{"key":823,"value":0},{"key":869,"value":0},{"key":896,"value":0},{"key":964,"value":0},{"key":970,"value":0},{"key":1630,"value":0},{"key":1671,"value":0},{"key":1672,"value":32768}],"varbit":[{"key":192,"value":0},{"key":199,"value":0},{"key":357,"value":0},{"key":386,"value":0},{"key":1990,"value":0},{"key":2310,"value":0},{"key":2328,"value":0},{"key":3534,"value":0},{"key":3618,"value":0},{"key":3741,"value":0},{"key":4494,"value":0},{"key":4538,"value":0},{"key":4566,"value":0},{"key":4885,"value":0},{"key":4895,"value":0},{"key":4897,"value":0},{"key":5027,"value":0},{"key":5087,"value":0},{"key":5088,"value":0},{"key":5089,"value":0},{"key":5090,"value":0},{"key":5800,"value":0},{"key":5810,"value":0},{"key":6104,"value":0},{"key":7255,"value":0},{"key":7928,"value":0},{"key":9016,"value":0},{"key":10150,"value":0},{"key":13738,"value":0},{"key":13903,"value":0}],"member":true,"equipment":[],"inventory":[{"key":1935,"value":1},{"key":1993,"value":1},{"key":1993,"value":1},{"key":1993,"value":1},{"key":1993,"value":1},{"key":21146,"value":1},{"key":8008,"value":9},{"key":12625,"value":1},{"key":12625,"value":1},{"key":12625,"value":1}]},"requests":[{"start":{"x":3225,"y":3219,"z":0}},{"start":{"x":3113,"y":3179,"z":0}},{"start":{"x":2430,"y":3347,"z":0}},{"start":{"x":3406,"y":3156,"z":0}},{"start":{"x":3223,"y":3218,"z":0}},{"start":{"x":3244,"y":3210,"z":0}}]} [09:27:16] [Walker Engine] Got path: [(3223, 3218, 0), (3222, 3218, 0), (3221, 3218, 0), (3220, 3218, 0), (3219, 3218, 0), (3218, 3218, 0), (3217, 3218, 0), (3216, 3218, 0), (3215, 3218, 0), (3215, 3217, 0), (3215, 3216, 0), (3215, 3215, 0), (3215, 3214, 0), (3215, 3213, 0), (3215, 3212, 0), (3215, 3211, 0), (3214, 3210, 0), (3213, 3209, 0), (3212, 3209, 0), (3211, 3209, 0), (3210, 3209, 0), (3209, 3209, 0), (3208, 3209, 0), (3207, 3209, 0), (3206, 3209, 0), (3206, 3208, 0), (3205, 3209, 1), (3205, 3209, 2), (3205, 3210, 2), (3205, 3211, 2), (3205, 3212, 2), (3205, 3213, 2), (3205, 3214, 2), (3205, 3215, 2), (3205, 3216, 2), (3206, 3217, 2), (3206, 3218, 2), (3207, 3219, 2), (3208, 3219, 2), (3208, 3220, 2)] [09:27:16] [Walker Engine] We are already somewhere along the path. Destination details: PATH_DEBUG[ 3223, 3218, 0) -> FURTHEST_CLICKABLE_TILE -> (3222, 3218, 0) ] [09:27:16] [Walker Engine] Could not grab destination details. [09:27:16] [Walker Engine] Failed attempt on action. [09:27:17] [Walker Engine] Could not grab destination details. [09:27:18] [Walker Engine] Failed attempt on action. [09:27:21] [Walker Engine] Could not grab destination details. [09:27:21] [Walker Engine] Failed attempt on action. [09:27:23] [Walker Engine] Too many failed attempts [09:27:26] [DaxWalker] Generating path: {"player":{"attack":1,"defence":1,"strength":1,"hitpoints":10,"ranged":1,"prayer":1,"magic":1,"cooking":1,"woodcutting":1,"fletching":1,"fishing":1,"firemaking":1,"crafting":1,"smithing":1,"mining":1,"herblore":1,"agility":1,"thieving":1,"slayer":1,"farming":1,"runecrafting":1,"hunter":1,"construction":1,"setting":[{"key":10,"value":0},{"key":11,"value":0},{"key":17,"value":0},{"key":32,"value":3},{"key":63,"value":0},{"key":68,"value":0},{"key":71,"value":0},{"key":101,"value":4},{"key":111,"value":0},{"key":116,"value":0},{"key":131,"value":0},{"key":144,"value":0},{"key":145,"value":0},{"key":150,"value":0},{"key":165,"value":0},{"key":176,"value":0},{"key":179,"value":0},{"key":212,"value":0},{"key":273,"value":0},{"key":299,"value":0},{"key":302,"value":0},{"key":307,"value":0},{"key":314,"value":0},{"key":335,"value":0},{"key":347,"value":0},{"key":351,"value":0},{"key":365,"value":0},{"key":371,"value":0},{"key":387,"value":0},{"key":399,"value":0},{"key":425,"value":0},{"key":437,"value":0},{"key":440,"value":0},{"key":482,"value":0},{"key":622,"value":0},{"key":655,"value":0},{"key":671,"value":0},{"key":705,"value":0},{"key":794,"value":0},{"key":810,"value":33554432},{"key":823,"value":0},{"key":869,"value":0},{"key":896,"value":0},{"key":964,"value":0},{"key":970,"value":0},{"key":1630,"value":0},{"key":1671,"value":0},{"key":1672,"value":32768}],"varbit":[{"key":192,"value":0},{"key":199,"value":0},{"key":357,"value":0},{"key":386,"value":0},{"key":1990,"value":0},{"key":2310,"value":0},{"key":2328,"value":0},{"key":3534,"value":0},{"key":3618,"value":0},{"key":3741,"value":0},{"key":4494,"value":0},{"key":4538,"value":0},{"key":4566,"value":0},{"key":4885,"value":0},{"key":4895,"value":0},{"key":4897,"value":0},{"key":5027,"value":0},{"key":5087,"value":0},{"key":5088,"value":0},{"key":5089,"value":0},{"key":5090,"value":0},{"key":5800,"value":0},{"key":5810,"value":0},{"key":6104,"value":0},{"key":7255,"value":0},{"key":7928,"value":0},{"key":9016,"value":0},{"key":10150,"value":0},{"key":13738,"value":0},{"key":13903,"value":0}],"member":true,"equipment":[],"inventory":[{"key":1935,"value":1},{"key":1993,"value":1},{"key":1993,"value":1},{"key":1993,"value":1},{"key":1993,"value":1},{"key":21146,"value":1},{"key":8008,"value":9},{"key":12625,"value":1},{"key":12625,"value":1},{"key":12625,"value":1}]},"requests":[{"start":{"x":3225,"y":3219,"z":0}},{"start":{"x":3113,"y":3179,"z":0}},{"start":{"x":2430,"y":3347,"z":0}},{"start":{"x":3406,"y":3156,"z":0}},{"start":{"x":3223,"y":3218,"z":0}},{"start":{"x":3244,"y":3210,"z":0}}]} [09:27:26] [Walker Engine] Got path: [(3223, 3218, 0), (3222, 3218, 0), (3221, 3218, 0), (3220, 3218, 0), (3219, 3218, 0), (3218, 3218, 0), (3217, 3218, 0), (3216, 3218, 0), (3215, 3218, 0), (3215, 3217, 0), (3215, 3216, 0), (3215, 3215, 0), (3215, 3214, 0), (3215, 3213, 0), (3215, 3212, 0), (3215, 3211, 0), (3214, 3210, 0), (3213, 3209, 0), (3212, 3209, 0), (3211, 3209, 0), (3210, 3209, 0), (3209, 3209, 0), (3208, 3209, 0), (3207, 3209, 0), (3206, 3209, 0), (3206, 3208, 0), (3205, 3209, 1), (3205, 3209, 2), (3205, 3210, 2), (3205, 3211, 2), (3205, 3212, 2), (3205, 3213, 2), (3205, 3214, 2), (3205, 3215, 2), (3205, 3216, 2), (3206, 3217, 2), (3206, 3218, 2), (3207, 3219, 2), (3208, 3219, 2), (3208, 3220, 2)] [09:27:26] [Walker Engine] We are already somewhere along the path. Destination details: PATH_DEBUG[ 3223, 3218, 0) -> FURTHEST_CLICKABLE_TILE -> (3222, 3218, 0) ] [09:27:26] [Walker Engine] Could not grab destination details. [09:27:26] [Walker Engine] Failed attempt on action. [09:27:27] [Walker Engine] Could not grab destination details. [09:27:28] [Walker Engine] Failed attempt on action. [09:27:31] [Walker Engine] Could not grab destination details. [09:27:32] [Walker Engine] Failed attempt on action. [09:27:34] [Walker Engine] Too many failed attempts [09:27:38] [DaxWalker] Generating path: {"player":{"attack":1,"defence":1,"strength":1,"hitpoints":10,"ranged":1,"prayer":1,"magic":1,"cooking":1,"woodcutting":1,"fletching":1,"fishing":1,"firemaking":1,"crafting":1,"smithing":1,"mining":1,"herblore":1,"agility":1,"thieving":1,"slayer":1,"farming":1,"runecrafting":1,"hunter":1,"construction":1,"setting":[{"key":10,"value":0},{"key":11,"value":0},{"key":17,"value":0},{"key":32,"value":3},{"key":63,"value":0},{"key":68,"value":0},{"key":71,"value":0},{"key":101,"value":4},{"key":111,"value":0},{"key":116,"value":0},{"key":131,"value":0},{"key":144,"value":0},{"key":145,"value":0},{"key":150,"value":0},{"key":165,"value":0},{"key":176,"value":0},{"key":179,"value":0},{"key":212,"value":0},{"key":273,"value":0},{"key":299,"value":0},{"key":302,"value":0},{"key":307,"value":0},{"key":314,"value":0},{"key":335,"value":0},{"key":347,"value":0},{"key":351,"value":0},{"key":365,"value":0},{"key":371,"value":0},{"key":387,"value":0},{"key":399,"value":0},{"key":425,"value":0},{"key":437,"value":0},{"key":440,"value":0},{"key":482,"value":0},{"key":622,"value":0},{"key":655,"value":0},{"key":671,"value":0},{"key":705,"value":0},{"key":794,"value":0},{"key":810,"value":33554432},{"key":823,"value":0},{"key":869,"value":0},{"key":896,"value":0},{"key":964,"value":0},{"key":970,"value":0},{"key":1630,"value":0},{"key":1671,"value":0},{"key":1672,"value":32768}],"varbit":[{"key":192,"value":0},{"key":199,"value":0},{"key":357,"value":0},{"key":386,"value":0},{"key":1990,"value":0},{"key":2310,"value":0},{"key":2328,"value":0},{"key":3534,"value":0},{"key":3618,"value":0},{"key":3741,"value":0},{"key":4494,"value":0},{"key":4538,"value":0},{"key":4566,"value":0},{"key":4885,"value":0},{"key":4895,"value":0},{"key":4897,"value":0},{"key":5027,"value":0},{"key":5087,"value":0},{"key":5088,"value":0},{"key":5089,"value":0},{"key":5090,"value":0},{"key":5800,"value":0},{"key":5810,"value":0},{"key":6104,"value":0},{"key":7255,"value":0},{"key":7928,"value":0},{"key":9016,"value":0},{"key":10150,"value":0},{"key":13738,"value":0},{"key":13903,"value":0}],"member":true,"equipment":[],"inventory":[{"key":1935,"value":1},{"key":1993,"value":1},{"key":1993,"value":1},{"key":1993,"value":1},{"key":1993,"value":1},{"key":21146,"value":1},{"key":8008,"value":9},{"key":12625,"value":1},{"key":12625,"value":1},{"key":12625,"value":1}]},"requests":[{"start":{"x":3225,"y":3219,"z":0}},{"start":{"x":3113,"y":3179,"z":0}},{"start":{"x":2430,"y":3347,"z":0}},{"start":{"x":3406,"y":3156,"z":0}},{"start":{"x":3223,"y":3218,"z":0}},{"start":{"x":3241,"y":3210,"z":0}}]} [09:27:38] [Walker Engine] Got path: [(3223, 3218, 0), (3222, 3218, 0), (3221, 3218, 0), (3220, 3218, 0), (3219, 3218, 0), (3218, 3218, 0), (3217, 3218, 0), (3216, 3218, 0), (3215, 3218, 0), (3215, 3217, 0), (3215, 3216, 0), (3215, 3215, 0), (3215, 3214, 0), (3215, 3213, 0), (3215, 3212, 0), (3215, 3211, 0), (3214, 3210, 0), (3213, 3209, 0), (3212, 3209, 0), (3211, 3209, 0), (3210, 3209, 0), (3209, 3209, 0), (3208, 3209, 0), (3207, 3209, 0), (3206, 3209, 0), (3206, 3208, 0), (3205, 3209, 1), (3205, 3209, 2), (3205, 3210, 2), (3205, 3211, 2), (3205, 3212, 2), (3205, 3213, 2), (3205, 3214, 2), (3205, 3215, 2), (3205, 3216, 2), (3206, 3217, 2), (3206, 3218, 2), (3207, 3219, 2), (3208, 3219, 2), (3208, 3220, 2)] [09:27:38] [Walker Engine] We are already somewhere along the path. Destination details: PATH_DEBUG[ 3223, 3218, 0) -> FURTHEST_CLICKABLE_TILE -> (3222, 3218, 0) ] [09:27:38] [Walker Engine] Could not grab destination details. [09:27:38] [Walker Engine] Failed attempt on action.

FALSkills commented 1 year ago

Can you please let me know if this issue is still occurring? The TRiBot library was not being updated properly up until yesterday I believe.

BegTribot commented 1 year ago

I believe it's still happening I've downloaded the src and integrated it directly in my scripts, i called it "Custom DaxWalker" and "Custom Walker Engine"

The debug messages:

[05:29:00] [Custom DaxWalker] Generating path: {"requests":[{"start":{"z":0,"y":3219,"x":3225},"end":{"z":0,"y":3267,"x":3092}},{"start":{"z":0,"y":3496,"x":3087},"end":{"z":0,"y":3267,"x":3092}},{"start":{"z":0,"y":3176,"x":2918},"end":{"z":0,"y":3267,"x":3092}},{"start":{"z":0,"y":3251,"x":3105},"end":{"z":0,"y":3267,"x":3092}},{"start":{"z":0,"y":3163,"x":3293},"end":{"z":0,"y":3267,"x":3092}},{"start":{"z":0,"y":3218,"x":3223},"end":{"z":0,"y":3267,"x":3092}},{"start":{"z":0,"y":3286,"x":3168},"end":{"z":0,"y":3267,"x":3092}}],"player":{"varbit":[{"key":192,"value":0},{"key":199,"value":0},{"key":357,"value":3},{"key":386,"value":0},{"key":1990,"value":0},{"key":2310,"value":0},{"key":2328,"value":0},{"key":3534,"value":0},{"key":3618,"value":0},{"key":3741,"value":0},{"key":4494,"value":0},{"key":4538,"value":0},{"key":4566,"value":0},{"key":4885,"value":0},{"key":4895,"value":0},{"key":4897,"value":1},{"key":5027,"value":0},{"key":5087,"value":0},{"key":5088,"value":0},{"key":5089,"value":0},{"key":5090,"value":0},{"key":5800,"value":0},{"key":5810,"value":0},{"key":6071,"value":0},{"key":6104,"value":0},{"key":7255,"value":0},{"key":7928,"value":0},{"key":9016,"value":0},{"key":10150,"value":0},{"key":13719,"value":0},{"key":13738,"value":0},{"key":13903,"value":0}],"crafting":19,"cooking":71,"smithing":1,"slayer":15,"construction":1,"defence":13,"fishing":3,"setting":[{"key":10,"value":0},{"key":11,"value":0},{"key":17,"value":0},{"key":32,"value":3},{"key":63,"value":6},{"key":68,"value":0},{"key":71,"value":0},{"key":101,"value":16},{"key":111,"value":0},{"key":116,"value":0},{"key":131,"value":0},{"key":144,"value":100},{"key":145,"value":0},{"key":150,"value":0},{"key":165,"value":0},{"key":176,"value":0},{"key":179,"value":0},{"key":212,"value":0},{"key":273,"value":0},{"key":299,"value":0},{"key":302,"value":61},{"key":307,"value":0},{"key":314,"value":0},{"key":335,"value":0},{"key":347,"value":0},{"key":351,"value":0},{"key":365,"value":0},{"key":371,"value":0},{"key":387,"value":0},{"key":399,"value":0},{"key":425,"value":0},{"key":437,"value":0},{"key":440,"value":0},{"key":482,"value":0},{"key":622,"value":0},{"key":655,"value":0},{"key":671,"value":0},{"key":705,"value":0},{"key":794,"value":0},{"key":810,"value":33554432},{"key":823,"value":0},{"key":869,"value":0},{"key":896,"value":0},{"key":964,"value":0},{"key":970,"value":0},{"key":1630,"value":0},{"key":1671,"value":0},{"key":1672,"value":32768}],"inventory":[{"key":6,"value":1},{"key":379,"value":1},{"key":11976,"value":1},{"key":4155,"value":1},{"key":12625,"value":1},{"key":379,"value":1},{"key":379,"value":1},{"key":379,"value":1},{"key":379,"value":1},{"key":379,"value":1},{"key":379,"value":1},{"key":379,"value":1},{"key":379,"value":1},{"key":379,"value":1},{"key":379,"value":1},{"key":379,"value":1},{"key":379,"value":1},{"key":8008,"value":1},{"key":8,"value":1},{"key":2,"value":3425},{"key":10,"value":1},{"key":169,"value":1},{"key":12,"value":1}],"woodcutting":35,"thieving":1,"hunter":9,"hitpoints":41,"mining":1,"fletching":1,"firemaking":9,"walkerPreferences":[],"ranged":52,"prayer":50,"attack":30,"agility":1,"herblore":1,"equipment":[{"key":1169,"value":1},{"key":11976,"value":1},{"key":857,"value":1},{"key":1131,"value":1},{"key":1099,"value":1},{"key":1065,"value":1},{"key":1061,"value":1},{"key":892,"value":1980}],"magic":50,"strength":30,"member":true,"runecrafting":1,"farming":1}} [05:29:00] [Custom Walker Engine] Got path: [(3105, 3251, 0), (3105, 3252, 0), (3105, 3253, 0), (3104, 3254, 0), (3103, 3255, 0), (3103, 3256, 0), (3103, 3257, 0), (3103, 3258, 0), (3103, 3259, 0), (3103, 3260, 0), (3103, 3261, 0), (3103, 3262, 0), (3103, 3263, 0), (3103, 3264, 0), (3103, 3265, 0), (3103, 3266, 0), (3103, 3267, 0), (3103, 3268, 0), (3103, 3269, 0), (3103, 3270, 0), (3103, 3271, 0), (3102, 3271, 0), (3101, 3271, 0), (3100, 3271, 0), (3099, 3271, 0), (3098, 3271, 0), (3097, 3271, 0), (3096, 3271, 0), (3095, 3271, 0), (3094, 3271, 0), (3093, 3270, 0), (3092, 3269, 0), (3092, 3268, 0), (3092, 3267, 0)] [05:29:00] [Custom Walker Engine] We are already somewhere along the path. Destination details: PATH_DEBUG[ 3103, 3265, 0) -> FURTHEST_CLICKABLE_TILE -> (3103, 3266, 0) ] [05:29:00] [Custom Walker Engine] Could not grab destination details. [05:29:00] [Custom Walker Engine] Failed attempt on action. [05:29:01] [Custom Walker Engine] Could not grab destination details. [05:29:02] [Custom Walker Engine] Failed attempt on action. [05:29:03] [Custom Walker Engine] Could not grab destination details. [05:29:04] [Custom Walker Engine] Failed attempt on action.

Why does this check prevent a teleport? Shouldn't it use the teleport anyway if it needs to?

PathAnalyzer.DestinationDetails destinationDetails = PathAnalyzer.furthestReachableTile(path);
if (destinationDetails != null && !destinationDetails.getDestination().getRSTile().equals(startPosition)) {
      log("We are already somewhere along the path. Destination details: " + destinationDetails);
      return true;
}
FALSkills commented 1 year ago

Looks like the PathAnalyzer isn't calculating things properly in this situation, it is picking (3103, 3266, 0) as the closest tile rather than the start of the path at the Draynor glory telespot. If we add a simple check for if the destination details' tile is on the screen, that can probably replace the tile comparison. I've tested it locally for this situation and it seems to be working. 7cb75390ca8dd23a265f0fb98188bc2f3f358990

BegTribot commented 1 year ago

Looks fixed so far, but the issue doesn't happen very often I'd say we can close and i'll reopen if needed