search

itsdax / Runescape-Web-Walker-Engine

A navigation engine for OSRS written for TriBot
https://tribot.org/
Apache License 2.0
81 stars 37 forks source link

Trying to minigame teleport while in combat #231

Closed BegTribot closed 10 months ago

BegTribot commented 10 months ago

image

Removed player data for user's privacy.

[20:56:29] [DaxWalker] Generating path: {"requests":[{"start":{"y":3379,"x":2966,"z":0}},{"start":{"y":3550,"x":2882,"z":0}},{"start":{"y":3366,"x":3190,"z":0}},{"start":{"y":3486,"x":3053,"z":0}},{"start":{"y":3442,"x":2656,"z":0}},{"start":{"y":3496,"x":3087,"z":0}},{"start":{"y":3176,"x":2918,"z":0}},{"start":{"y":3251,"x":3105,"z":0}},{"start":{"y":3163,"x":3293,"z":0}},{"start":{"y":4938,"x":2207,"z":0}},{"start":{"y":3092,"x":2442,"z":0}},{"start":{"y":3635,"x":3149,"z":0}},{"start":{"y":3147,"x":3361,"z":0}},{"start":{"y":3635,"x":3151,"z":0}},{"start":{"y":2656,"x":2653,"z":0}},{"start":{"y":2857,"x":2210,"z":0}},{"start":{"y":5181,"x":2402,"z":0}},{"start":{"y":9823,"x":3029,"z":0}}], [20:56:29] [Walker Engine] Got path: [(2210, 2857, 0), (2211, 2857, 0), (2212, 2858, 0), (2212, 2859, 0)] [20:56:29] PathAnalyzer attempt to find closest tile in path: null [(2210, 2857, 0), (2211, 2857, 0), (2212, 2858, 0), (2212, 2859, 0)] [20:56:29] [Walker Engine] Using teleport: SOUL_WARS_MINIGAME with cost: 10 [20:56:34] WARNING [Walker Engine] Failed to handle teleports... [20:56:37] [DaxWalker] Generating path: {"requests":[{"start":{"y":3379,"x":2966,"z":0}},{"start":{"y":3550,"x":2882,"z":0}},{"start":{"y":3366,"x":3190,"z":0}},{"start":{"y":3486,"x":3053,"z":0}},{"start":{"y":3442,"x":2656,"z":0}},{"start":{"y":3496,"x":3087,"z":0}},{"start":{"y":3176,"x":2918,"z":0}},{"start":{"y":3251,"x":3105,"z":0}},{"start":{"y":3163,"x":3293,"z":0}},{"start":{"y":4938,"x":2207,"z":0}},{"start":{"y":3092,"x":2442,"z":0}},{"start":{"y":3635,"x":3149,"z":0}},{"start":{"y":3147,"x":3361,"z":0}},{"start":{"y":3635,"x":3151,"z":0}},{"start":{"y":2656,"x":2653,"z":0}},{"start":{"y":2857,"x":2210,"z":0}},{"start":{"y":5181,"x":2402,"z":0}},{"start":{"y":9823,"x":3029,"z":0}}], [20:56:37] [Walker Engine] Got path: [(2210, 2857, 0), (2211, 2857, 0), (2212, 2858, 0), (2212, 2859, 0)] [20:56:37] PathAnalyzer attempt to find closest tile in path: null [(2210, 2857, 0), (2211, 2857, 0), (2212, 2858, 0), (2212, 2859, 0)] [20:56:37] [Walker Engine] Using teleport: SOUL_WARS_MINIGAME with cost: 10

FALSkills commented 10 months ago

Is this using the latest version of the library? there is indeed a check for isInCombat for minigame teleports

https://github.com/itsdax/Runescape-Web-Walker-Engine/blob/00c63b605521b2dec0f5034a15a3156b73ab8842/src/main/java/dax/teleports/Teleport.java#L1023

BegTribot commented 10 months ago

Yes the only difference i have is a null check on Player.getRSPlayer image

Maybe player was not in combat, tries the minigame teleport and got in combat meanwhile I noticed it doesn't break the wait condition if it gets in combat https://github.com/itsdax/Runescape-Web-Walker-Engine/blob/00c63b605521b2dec0f5034a15a3156b73ab8842/src/main/java/dax/walker_engine/WalkerEngine.java#L335-L337 But it's weird it kept trying to teleport when in combat

FALSkills commented 10 months ago

you didn't copy it over correctly. your local library only returns true if they are in combat.