search

itsdax / Runescape-Web-Walker-Engine

A navigation engine for OSRS written for TriBot
https://tribot.org/
Apache License 2.0
81 stars 39 forks source link

[Request] DaxWalker.walkToBank considering returns #89

Open BegTribot opened 3 years ago

BegTribot commented 3 years ago

Add an option to walk to the closest bank considering the path it must take to return back to the current position. Example: DaxWalker.walkToBank while at lumbridge cow pen uses ring of wealth to teleport to the grand exchange bank. After banking i want it to return back to the cow pen.

I believe if it had a flag to indicate it is to come back after banking, it'd find the lumbridge castle to be closer.

Note: Its aio script, otherwise i could just do walkToBank(Bank.LUMBRIDGE). For now i'll allow the user to select where to bank, but i believe this daxwalker feature would be useful to others too.

FALSkills commented 2 years ago

This would require an additional endpoint and logic that ultimately would require @itsdax to implement, please reach out to him if this is something you would still like to pursue.

itsdax commented 2 years ago

This is pretty feasible, and not too hard to add. I can add it to server side when I have time.

JamieTribot commented 2 years ago

@itsdax Any thoughts / update to this? :)

itsdax commented 2 years ago

I've been giving it a thought and the issue I'm trying to figure out how to handle is how to determine the "state" of the bot when it returns, while it is computing the banking route.

For ex: Script: Go to spot A to gather resources, and bank.

To get to spot A, we withdraw 1 varrock teleport tab. When banking, it has to "know" that the route back, we will have a varrock teleport, but we don't have it now. This is an issue because the "round" trip is computed with or without this teleport, and can return drastically different behavior.

BegTribot commented 2 years ago

Don't think its possible for daxwalker to know which teleports will be withdraw from the bank. Because that logic is on the script itself. Maybe add an optional argument to let us decide that? E.g. DaxWalker.walkToBank(Teleport... additionalReturnTeleports)

Theres another issue easier to solve related to teleports: let say we're here in keldagrim image with a ring of wealth (2) we could telepot to g.e. and come back using both charges but with a ring of wealth (1) that's no longer possible