search

itsdfish / SequentialSamplingModels.jl

A unified interface for simulating and evaluating sequential sampling models in Julia.
https://itsdfish.github.io/SequentialSamplingModels.jl/dev/
MIT License
27 stars 4 forks source link

CompatHelper: bump compat for DynamicPPL to 0.25, (keep existing compat) #67

Closed github-actions[bot] closed 6 months ago

github-actions[bot] commented 7 months ago

This pull request changes the compat entry for the DynamicPPL package from 0.22.0,0.23.0,0.24.0 to 0.22.0,0.23.0,0.24.0, 0.25. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

github-actions[bot] commented 7 months ago

Benchmark Results

master fb557323232487... master/fb557323232487...
logpdf/("SequentialSamplingModels.DDM", 10) 1.67 ± 0.11 μs 1.67 ± 0.12 μs 0.999
logpdf/("SequentialSamplingModels.DDM", 100) 17.3 ± 0.75 μs 17.3 ± 0.77 μs 1
logpdf/("SequentialSamplingModels.LBA", 10) 2.5 ± 0.29 μs 2.46 ± 0.2 μs 1.02
logpdf/("SequentialSamplingModels.LBA", 100) 23.4 ± 0.56 μs 23.4 ± 0.59 μs 1
logpdf/("SequentialSamplingModels.LNR", 10) 1 ± 0.16 μs 1 ± 0.15 μs 0.997
logpdf/("SequentialSamplingModels.LNR", 100) 8.66 ± 0.31 μs 8.64 ± 0.32 μs 1
logpdf/("SequentialSamplingModels.RDM", 10) 2.57 ± 0.21 μs 2.57 ± 0.19 μs 0.998
logpdf/("SequentialSamplingModels.RDM", 100) 25.1 ± 0.68 μs 25 ± 0.68 μs 1
logpdf/("SequentialSamplingModels.Wald", 10) 0.227 ± 0.17 μs 0.228 ± 0.16 μs 0.996
logpdf/("SequentialSamplingModels.Wald", 100) 2 ± 0.038 μs 2 ± 0.046 μs 1
logpdf/("SequentialSamplingModels.WaldMixture", 10) 1.08 ± 0.16 μs 1.08 ± 0.16 μs 1
logpdf/("SequentialSamplingModels.WaldMixture", 100) 10.6 ± 0.16 μs 10.5 ± 0.16 μs 1
rand/("SequentialSamplingModels.DDM", 10) 3.9 ± 0.55 μs 3.95 ± 0.54 μs 0.988
rand/("SequentialSamplingModels.DDM", 100) 0.0384 ± 0.0019 ms 0.0384 ± 0.0019 ms 1
rand/("SequentialSamplingModels.LBA", 10) 3.26 ± 0.31 μs 3.28 ± 0.32 μs 0.994
rand/("SequentialSamplingModels.LBA", 100) 16.6 ± 1.4 μs 16.5 ± 0.3 μs 1.01
rand/("SequentialSamplingModels.LCA", 10) 0.767 ± 0.26 ms 0.807 ± 0.27 ms 0.951
rand/("SequentialSamplingModels.LCA", 100) 8.28 ± 0.23 ms 8.77 ± 0.25 ms 0.945
rand/("SequentialSamplingModels.LNR", 10) 1.1 ± 0.44 μs 1.1 ± 0.42 μs 0.996
rand/("SequentialSamplingModels.LNR", 100) 7.38 ± 3.8 μs 7.36 ± 3.8 μs 1
rand/("SequentialSamplingModels.RDM", 10) 1.37 ± 0.42 μs 1.38 ± 0.41 μs 0.994
rand/("SequentialSamplingModels.RDM", 100) 10.8 ± 3.8 μs 14 ± 3.8 μs 0.773
rand/("SequentialSamplingModels.Wald", 10) 0.464 ± 0.16 μs 0.466 ± 0.16 μs 0.995
rand/("SequentialSamplingModels.Wald", 100) 2.91 ± 0.2 μs 2.88 ± 0.21 μs 1.01
rand/("SequentialSamplingModels.WaldMixture", 10) 1.18 ± 0.15 μs 1.18 ± 0.15 μs 1
rand/("SequentialSamplingModels.WaldMixture", 100) 11.3 ± 0.19 μs 11.3 ± 0.19 μs 1
simulate/SequentialSamplingModels.DDM 3.77 ± 1.5 μs 3.75 ± 1.6 μs 1
simulate/SequentialSamplingModels.LBA 2.2 ± 0.076 μs 2.93 ± 1.6 μs 0.752
simulate/SequentialSamplingModels.LCA 0.105 ± 0.021 ms 0.102 ± 0.021 ms 1.03
simulate/SequentialSamplingModels.RDM 0.0981 ± 0.034 ms 0.0969 ± 0.03 ms 1.01
simulate/SequentialSamplingModels.Wald 9.35 ± 4.3 μs 9.62 ± 4.7 μs 0.972
simulate/SequentialSamplingModels.WaldMixture 4.04 ± 1.6 μs 4.09 ± 1.5 μs 0.987
time_to_load 3.83 ± 0.018 s 3.84 ± 0.022 s 0.999

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

itsdfish commented 7 months ago

Fails because Turing does not support DynamicPPL 0.25.0. Merge when supported.