itsdinkd / AQM2

1.17 - 1.19.2
https://www.curseforge.com/minecraft/modpacks/another-quality-modpack-2
10 stars 6 forks source link

[BUG] copper plate not craftable in the bronze compressor in singleplayer, but it is on the official servers #74

Closed FederAndInk closed 2 years ago

FederAndInk commented 2 years ago

Modpack Version 1.4.1

Minecraft Version 1.18.2

Describe the crash or bug The copper plate is not craftable in the bronze compressor in singleplayer, but it is on the official servers. We can see the recipe in the official servers but not in single player

Steps to reproduce the behavior: try to put a copper ingot into a bronze compressor with steam. or see the recipe in REI

Expected behavior What is the expected outcome?

Screenshots

Official servers:

Screenshot_20220717_204751

SinglePlayer:

Screenshot_20220717_205147

Crash log or latest.log.log use pastebin.com for your log

Additional context Any additional context?

itsdinkd commented 2 years ago

This is an issue with REI and will need to be reported to their github

FederAndInk commented 2 years ago

I mean, its not even craftable in the bronze compressor. It should be right?

FederAndInk commented 2 years ago

Just a follow up on this issue, the problem lies in kubejs not loading the scripts in the same order on server vs single player.

The server remove script needs to be loaded before the server unification script, I think they need to be either merged to force the order or the remove script needs to be loaded at the end of the unification script. Or maybe we can specify script dependencies in kubejs?

Basically, the remove script remove the MI copper_plate recipe then the unification script change the recipe from MI copper_plate to TR copper_plate, but it can't be changed if the recipe has been removed first.

itsdinkd commented 2 years ago

Great find!!

On Fri, Jul 22, 2022, 9:39 AM Ludovic J @.***> wrote:

Just a follow up on this issue, the problem lies in kubejs not loading the scripts in the same order on server vs single player.

The server remove script needs to be loaded before the server unification script, I think they need to be either merged to force the order or the remove script needs to be loaded at the end of the unification script. Or maybe we can specify script dependencies in kubejs?

Basically, the remove script remove the MI copper_plate recipe then the unification script change the recipe from MI copper_plate to TR copper_plate, but it can't be changed if the recipe has been removed first.

— Reply to this email directly, view it on GitHub https://github.com/itsdinkd/AQM2/issues/74#issuecomment-1192753089, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIL5CKFXVOQW3N37MPDJB5TVVLFD3ANCNFSM532FRVKA . You are receiving this because you were assigned.Message ID: @.***>

Seceroth commented 2 years ago

You can set the script priority with for example //priority: 100 At the top of a script to set the priority, higher number = higher priority IIRC

itsdinkd commented 2 years ago

You can set the script priority with for example //priority: 100 At the top of a script to set the priority, higher number = higher priority IIRC

Ahh. Wasn't aware of that, thank you.

itsdinkd commented 2 years ago

Fixed in next version!