Closed DomGrieco closed 7 years ago
this comes from gw2 api as buff:
"infix_upgrade": {
"id": 599,
"buff": {
"skill_id": 15755,
"description": "+32 Power\n+18 Ferocity\n+18 Precision\n+5 Agony Resistance"
},
"attributes": [
{
"attribute": "Power",
"modifier": 126
},
{
"attribute": "Precision",
"modifier": 85
},
{
"attribute": "CritDamage",
"modifier": 85
}
]
we can eliminate the rendering of that easily, but as i don't have much experience with other items, from reading the API wiki, looks like i can eliminate it for non-UpgradeComponent items, @madou can you confirm that change?
sure, sounds good. make a update the changelog, update the package.json version (increment patch) and make a pr :)
I'm fixing all blocking issues for @DomGrieco into a branch, then i'll update changelog with all fixes and such, no worries 👍
P.S @madou
why not using standard-version?
or at least just conventional-changlog
cool, sounds great!
no reason for not using standard-version et al really, would be happy to look into using it if it'd streamline things
it basically: