itsdouges / armory-app

🛡 Guild Wars 2 Armory | gw2armory.com
https://gw2armory.com
BSD 3-Clause Clear License
72 stars 22 forks source link

Embedded Tooltips - Damage values aren't accurate #190

Closed DomGrieco closed 7 years ago

DomGrieco commented 7 years ago

This will require a lot of work. Adding the issue here so it's logged.

damage_one

DxCx commented 7 years ago

this is because the skill fact returns hit_count: 1 i think that for Damage we need to add some calculation formula. i can do it dummy so it will show exactly as Gw2Wiki (1 hit count = 266 dmg) so (266 * data.hit_count * data. dmg_multiplier) (in this case both are 1) https://wiki.guildwars2.com/wiki/%22Feel_the_Burn!%22

please enlighten me if you have a better way of solving this..

itsdouges commented 7 years ago

im happy using the 1 hit count = 266 damage, easiest and most straight forward.

would be good to get proper calculations in the armory side of things when viewing someones character, but uh, maybe later..

DxCx commented 7 years ago

alright, thanks, done.