search

itsdouges / armory-app

🛡 Guild Wars 2 Armory | gw2armory.com
https://gw2armory.com
BSD 3-Clause Clear License
72 stars 22 forks source link

fixing bug when id is string "all" #350

Closed esunder closed 7 years ago

esunder commented 7 years ago

When certain fetch calls are made with id = ['all'], the id validation previously failed because 'all' is neither an object or an integer. ActualId would be set to NaN and the filter function would return false.

codecov[bot] commented 7 years ago

Codecov Report

Merging #350 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #350   +/-   ##
======================================
  Coverage    8.95%   8.95%           
======================================
  Files         234     234           
  Lines        2568    2568           
======================================
  Hits          230     230           
  Misses       2338    2338
Impacted Files Coverage Δ
src/features/Gw2/actions.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1b6256...225aa01. Read the comment docs.

itsdouges commented 7 years ago

thanks @esunder