Open lukekaalim opened 1 year ago
Wait hang on - Dougall? I just checked your profile to see if you were active on github and I recognized your face! I'm pretty sure we worked together at 9now for exactly one week lol. How's hockey?
Great plugin btw - I know this is like a year old but this really saved my ass when I was doing some deno-vite stuff
Haha mate I saw your profile and I was like wait a second I know this guy 😂
Yeah we did!! How's things? Where are you at now?
Hockey is great just slid into the grand final which is on in a few weeks 💪.
Will look at the PR soon, this whole lib was originally slated to handle npm specifiers but then Deno pivoted back to package.json so was mostly unneeded. But the Deno https specifiers still are needed at least.
Expected behavior: Both single quoted
import x from 'y';
and double-quotedimport x from "y";
imports should be remapped to localhost.Observed behaviour: Only single quoted import statements get remapped, double-quoted statements get ignored - often meaning that they reach out to esm.sh servers and download (so its hard to notice that its not actually served locally since the code still runs like normal).
Reproduction case:
Here you can see Vite reaching out to both localhost & esm.sh to resolve React & React2.