itsdrnoob / DataMonitor

Data usage monitoring app for android.
GNU General Public License v3.0
532 stars 50 forks source link

Enhancement/kotlin transition #195

Open yatiksihag01 opened 10 months ago

yatiksihag01 commented 10 months ago

This PR extends #190 which was closed due to change in base branch. This PR also solved all the unexpected behaviour mentioned here.

itsdrnoob commented 10 months ago

Great, most of the previous issues were addressed but I've still noticed some issues.

Let me know what you think.

yatiksihag01 commented 10 months ago

requires additional refresh to update values on session change or after refreshing the main list

Hi @itsdrnoob , can you please explain a bit about first issue?

itsdrnoob commented 10 months ago

Hi @itsdrnoob , can you please explain a bit about first issue?

Sure. So basically both user app list as well as system apps list has to be refreshed on events like manual refresh in AppDataUsageFragment and session/type filter change, so that if opened, the up-to-date data is readily available in SystemDataUsageFragment. This was done by accessing the AppDataUsageFragment.mSystemList.

Also, here are some other details I've observed