itsdrnoob / DataMonitor

Data usage monitoring app for android.
GNU General Public License v3.0
558 stars 49 forks source link

Upload to F-Droid #23

Closed xmha97 closed 1 year ago

xmha97 commented 2 years ago

Please update this app to F-Droid and then put a link below on README.md

https://f-droid.org/packages/com.drnoob.datamonitor/

itsdrnoob commented 2 years ago

I'm currently working on pushing the app to play store. Will surely consider F-Droid as well

shuvashish76 commented 2 years ago

Currently available on IzzyOnDroid repo: https://apt.izzysoft.de/fdroid/index/apk/com.drnoob.datamonitor According to izzy's scanner it has GMS proprietary library. Screenshot_2022-08-08-13-53-21

itsdrnoob commented 2 years ago

According to izzy's scanner it has GMS proprietary library

I didn't see that coming.

shuvashish76 commented 2 years ago

I'm currently working on pushing the app to play store. Will surely consider F-Droid as well

As I see it's live on Playstore, any plans for F-Droid?

RFP: https://gitlab.com/fdroid/rfp/-/issues/2165

IzzySoft commented 2 years ago

I didn't see that coming.

I did. Need help? Culprit most likely is Google OSS Licenses plugin, which is known to drag that in as a dependency. See my snippet here for details and potential alternatives.

itsdrnoob commented 2 years ago

Culprit most likely is Google OSS Licenses plugin

I thought OSS plugin was seperate from other core GMS libs. I'll replace it with an alternative as you mentioned in the snippet. Appreciate your help.

IzzySoft commented 2 years ago

I thought OSS plugin was seperate from other core GMS libs.

Many thought so. And its name (carrying the term "OSS") with the plugin being Apache-2.0 licensed suggests as much. But we had it so many times already. No idea why (i.e. what for), but it drags in non-free deps (here: GMS). You can check for yourself to make sure: gradle :app:dependencies should give you the dependency tree.

itsdrnoob commented 2 years ago

You can check for yourself to make sure

Just checked the dependency tree, OSS plugin indeed has other GMS modules bundled within.

shuvashish76 commented 2 years ago

@IzzySoft GMS removed, but still shows "Anti-Features" tag on your repo.

IzzySoft commented 2 years ago

NonFreeDep is one of the AFs that need manual care. Thanks for the notification – checked and removed the AF. Will take effect with the next sync today around 6 pm UTC then.

jcperil commented 1 year ago

What is the update on this issue?

itsdrnoob commented 1 year ago

What is the update on this issue?

No updates yet, ig I've to manually issue a PR in the fdroiddata repo.

IzzySoft commented 1 year ago

That would speed things up indeed. For starters, here comes a template for metadata/com.drnoob.datamonitor.yml you could start with:

Categories:
  - Internet
  - System
License: GPL-3.0-only
AuthorName: Dr.NooB
AuthorEmail: itsdrnoob@gmail.com
WebSite: https://forum.xda-developers.com/t/app-v1-0-data-monitor-track-all-your-data-usage-at-one-place.4356129/
SourceCode: https://github.com/itsdrnoob/DataMonitor
IssueTracker: https://github.com/itsdrnoob/DataMonitor/issues
Changelog: https://github.com/itsdrnoob/DataMonitor/releases

AutoName: Data Monitor

RepoType: git
Repo: https://github.com/itsdrnoob/DataMonitor

Builds:
  - versionName: v2.0.0
    versionCode: 7
    commit: v2.0.0
    subdir: app
    sudo:
      - apt-get update || apt-get update
      - apt-get install -y openjdk-11-jdk-headless
      - update-alternatives --auto java
    gradle:
      - yes

AutoUpdateMode: Version
UpdateCheckMode: Tags
CurrentVersion: v2.0.0
CurrentVersionCode: 7

Depending on the pipeline results, some adjustments might be needed – but if you're lucky it works out-of-the-box.

itsdrnoob commented 1 year ago

@IzzySoft Will make the necessary adjustments. Thanks for the template by the way.

IzzySoft commented 1 year ago

Gladly – and :crossed_fingers: for a smooth walk!

shuvashish76 commented 1 year ago

Live on F-Droid: https://www.f-droid.org/packages/com.drnoob.datamonitor/ 🎉

itsdrnoob commented 1 year ago

Well, time to close this issue as completed now :)