search

itsecurityco / to-google-translate

Highlight text on a web page and send it to Google Translate
https://addons.mozilla.org/firefox/addon/to-google-translate/
386 stars 114 forks source link

Browser problem #121

Open johntranz opened 3 years ago

johntranz commented 3 years ago

Recently I cannot use the utility of Friefox browser, it still works well before, if there is an update available, please show me how to fix it, thank you very much. ảnh

irashik commented 3 years ago

same problem. I tried to reinstall it - to no avail. Debian 5.9.0-1 firefox 82.0.2

IronShell1207 commented 3 years ago

same problem. I think it happened after the last update

mohamed-daif commented 3 years ago

same issue

Ubuntu 20.04.1 Firefox 82.0.2 (64-bit)

AleksBelytskyi commented 3 years ago

I have the same problem. Seems it happened after the last update of Firefox.

Windows 10 2004 Firefox 82.0.2 (64-bit)

piatachki commented 3 years ago

Same on Kubuntu 20.10 FF 82.0.3

itsecurityco commented 3 years ago

Hello, thank you for the report. I have uploaded an update that disabled modal feature to fix this issue. The new version is 4.1.0 and it's in the queue for been approved by the Firefox team. In the mean time you can change the option "Open in" from "Modal" to "New Tab" in the Options page.

manutoo commented 3 years ago

disabled modal feature to fix this issue.

That's not a fix if it's disabled... :-(

eremem commented 3 years ago

Hello, thank you for the report. I have uploaded an update that disabled modal feature to fix this issue. The new version is 4.1.0 and it's in the queue for been approved by the Firefox team. In the mean time you can change the option "Open in" from "Modal" to "New Tab" in the Options page.

I just updated to version 4.1.0 but the problem seems still to exist, at least when translating selected text in FF 82.0.3 (x64).

itsecurityco commented 3 years ago

Hello, when you try to translate text is the translation opened in a new tab or it still try to open the modal? Can you please delete and install the extension again? I’m thinking if it’s taking the previous configuration (open in modal) from previous versions.

Regards

El El mié, 11 de nov. de 2020 a la(s) 10:46, R.M.M notifications@github.com escribió:

Hello, thank you for the report. I have uploaded an update that disabled modal feature to fix this issue. The new version is 4.1.0 and it's in the queue for been approved by the Firefox team. In the mean time you can change the option "Open in" from "Modal" to "New Tab" in the Options page.

I just updated to version 4.1.0 but the problem seems still to exist, at least when translating selected text in FF 82.0.3 (x64).

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/itsecurityco/to-google-translate/issues/121#issuecomment-725431932, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANFE7VMBDOY7TAAJS4BN3TSPKIT3ANCNFSM4TOAKM2A .

-- Juan Escobar OSCE, OSCP, OSWP, CBR-AC Tel. +56 942342545

CONFIDENTIALITY The information in this email is confidential and may be legally privileged. It is intended solely for the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.

eremem commented 3 years ago

Hello, when you try to translate text is the translation opened in a new tab or it still try to open the modal? Can you please delete and install the extension again? I’m thinking if it’s taking the previous configuration (open in modal) from previous versions.

Hi! It seems to be the case - the translation was still shown in a pop-up dialog the whole time. I had to explicitly select Open in New Tab in the addon's settings, so that it's shown in a new tab and this works correctly. Will you be able to to restore the modal view anytime soon? It was quite a neat feature.

itsecurityco commented 3 years ago

Thank you for the feedback. I would like to restore the modal feature.

On Wed, Nov 11, 2020 at 11:02 AM R.M.M notifications@github.com wrote:

Hello, when you try to translate text is the translation opened in a new tab or it still try to open the modal? Can you please delete and install the extension again? I’m thinking if it’s taking the previous configuration (open in modal) from previous versions.

Hi! It seems to be the case - the translation was still shown in a pop-up dialog the whole time. I had to explicitly select Open in New Tab in the addon's settings, so that it's shown in a new tab and this works correctly. Will you be able to to restore the modal view anytime soon? It was quite a neat feature.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/itsecurityco/to-google-translate/issues/121#issuecomment-725440154, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANFE7TMP7ET2EE7ZEZTTILSPKKQBANCNFSM4TOAKM2A .

-- Juan Escobar OSCE, OSCP, OSWP, CBR-AC Tel. +56 942342545

CONFIDENTIALITY The information in this email is confidential and may be legally privileged. It is intended solely for the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.

eremem commented 3 years ago

Thank you for the feedback. I would like to restore the modal feature.

Glad to help! I thank you for this great addon! :)

cirocorvino commented 3 years ago

Thank you for the feedback. I would like to restore the modal feature.

Thank you for your very useful app. I hope you restore the modal feature, with the only "new tab" mode it loses a bit of its usability in my opinion.

Dakkuimm commented 3 years ago

@itsecurityco I would like to give some feedback regarding the disabling of the modal. I'm currently running Firefox 82.0.3 (64-bit). This thread seemed to be opened 5 days ago, but the modal was working for me as intended for the past 5 days, up until the newest update when it was removed. Occasionally I would get the loading icon like the original post showed, however I could easily fix it by clicking the icon twice to close and reopen the modal, and that would fix it for me. Right now though, the feature has been disabled despite it working fine for me. Disabling the feature only hides the problem and doesn't address the core issue.

Here are my two possible suggestions:

  1. Upon opening the modal, a pop-up or textbox with some sort of disclaimer saying "This feature may not work as intended in the latest version. This problem is being addressed." with the functionality of the modal completely intact.

or

  1. Implement the modal as an opt-in only feature in the extension menu until a fix is able to be pushed.

I appreciate this add-on a lot, and would love to re-enable this feature somehow. I use the modal a dozen times a day to write out kanji with the Japanese handwrite feature Google Translate has. Using the context menu is fine, but it takes three times as long and a bookmark on the browser becomes more convenient in my use case, as of now.

Thank you for taking the time to read this. I hope you take my suggestions into consideration, if it takes a while to completely fix the modal.

itsecurityco commented 3 years ago

Thank you for this feedback, I really appreciate it. I’m thinking that I can show the modal for previous versions of Firefox like 82.0.3 and fore to use new tab with lastest versions.

Do you use most the modal or icon feature?

Thank you again

El El jue, 12 de nov. de 2020 a la(s) 11:51, Dakkuimm < notifications@github.com> escribió:

@itsecurityco https://github.com/itsecurityco I would like to give some feedback regarding the disabling of the modal. I'm currently running Firefox 82.0.3 (64-bit). This thread seemed to be opened 5 days ago, but the modal was working for me as intended for the past 5 days, up until the newest update when it was removed. Occasionally I would get the loading icon like the original post showed, however I could easily fix it by clicking the icon twice to close and reopen the modal, and that would fix it for me. Right now though, the feature has been disabled despite it working fine for me. Disabling the feature only hides the problem and doesn't address the core issue.

Here are my two possible suggestions:

  1. Upon opening the modal, a pop-up or textbox with some sort of disclaimer saying "This feature may not work as intended in the latest version. This problem is being addressed." with the functionality of the modal completely intact.

or

  1. Implement the modal as an opt-in only feature in the extension menu until a fix is able to be pushed.

I appreciate this add-on a lot, and would love to re-enable this feature somehow. I use the modal a dozen times a day to write out kanji with the Japanese handwrite feature Google Translate has. Using the context menu is fine, but it takes three times as long and a bookmark on the browser becomes more convenient in my use case, as of now.

Thank you for taking the time to read this. I hope you take my suggestions into consideration, if it takes a while to completely fix the modal.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/itsecurityco/to-google-translate/issues/121#issuecomment-726125739, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANFE7WSNYU3G24GH6VSSI3SPPZAHANCNFSM4TOAKM2A .

-- Juan Escobar OSCE, OSCP, OSWP, CBR-AC Tel. +56 942342545

CONFIDENTIALITY The information in this email is confidential and may be legally privileged. It is intended solely for the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.

Dakkuimm commented 3 years ago

@itsecurityco I always use the icon that would normally be right here. I assumed modal in this case meant the icon. Whichever the option is that pops up the window on the top right of the browser.

image

itsecurityco commented 3 years ago

Modal and icon are two different features but both uses iframes to load google translate website witch is where the issue is raised

El El jue, 12 de nov. de 2020 a la(s) 12:17, Dakkuimm < notifications@github.com> escribió:

@itsecurityco https://github.com/itsecurityco I always use the icon that would normally be right here. I assumed modal in this case meant the icon.

[image: image] https://user-images.githubusercontent.com/70228327/98958189-0922b880-24d0-11eb-9b7a-d890f8486c29.png

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/itsecurityco/to-google-translate/issues/121#issuecomment-726142078, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANFE7XNVII4XQIV4YIRX4DSPP4ALANCNFSM4TOAKM2A .

-- Juan Escobar OSCE, OSCP, OSWP, CBR-AC Tel. +56 942342545

CONFIDENTIALITY The information in this email is confidential and may be legally privileged. It is intended solely for the addressee. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.

iddm commented 3 years ago

The modal dialogue appears for me on the latest version of the addon and the latest firefox as of now but doesn't load the google translate properly. It hasn't been showing it for quite a while now, actually, like 2-3 weeks now.

laurent-simon commented 3 years ago

According to this Firefox bug report, it is not a bug directly related to Firefox. It seems to be a restriction of Google Translate, the effects of which are only visible in Firefox 82.0.3+.

If it is the case, restoring the modal dialog can be a bit difficult...

TonyGravagno commented 3 years ago

Adding a +1 here for notifications. I'm running Firefox 84 with TGT plugin v4.1.0. Yes, switching from modal to new tab does work. Looking forward to modal support. Sincere thanks for a very useful plugin!