this PR integrates PHPStan into the Clockwork sources. The analyzer is automatically executed on every push using a Github action. As alternatives to PHPStan, there would be Psalm and perhaps SonarQube. I have worked with Psalm before and it works similarly to PHPStan. About SonarQube, I can't say much, but it seems to have a much larger scope. In particular, it provides a multi-language (not just PHP) framework and also includes support for making code reviews.
If you look at the README, there is a section on how to work with PHPStan, also the commit messages should contain some interesting context infos.
As for what drove me to develop this
It helps find bugs (two of them just recently fixed as byproducts from this integration).
It prevents regressions.
It gives the devs more time to work on the important stuff. ;)
Greetings,
this PR integrates PHPStan into the Clockwork sources. The analyzer is automatically executed on every push using a Github action. As alternatives to PHPStan, there would be Psalm and perhaps SonarQube. I have worked with Psalm before and it works similarly to PHPStan. About SonarQube, I can't say much, but it seems to have a much larger scope. In particular, it provides a multi-language (not just PHP) framework and also includes support for making code reviews.
If you look at the README, there is a section on how to work with PHPStan, also the commit messages should contain some interesting context infos.
As for what drove me to develop this
Cheers!
Uli