search

itsgoingd / clockwork

Clockwork - php dev tools in your browser - server-side component
https://underground.works/clockwork
MIT License
5.69k stars 321 forks source link

No such file in iframe.html.php #706

Closed fedorovsergey closed 1 month ago

fedorovsergey commented 5 months ago

In file https://github.com/itsgoingd/clockwork/blob/743aee4f29ec7773a05562865aa8a7655d25a868/Clockwork/Support/Vanilla/iframe.html.php#L16 attached an svg $asset('img/icons/safari-pinned-tab.svg') and $asset('img/icons/msapplication-icon-144x144.png') but in project is no such files. How does it works?

UlrichEckhardt commented 5 months ago

You need to take a look at $asset, which refers to a PHP function which resolves these paths to the correct location.

fedorovsergey commented 5 months ago

Thanks for the reply! I look at the function, it outputs path to icons, but in directory no such file image However apple-touch-icon-152x152.png exists. Thats why I think some mistake here

itsgoingd commented 5 months ago

Hey, I think I forgot to update the iframe when updating the web UI recently, thanks for bringing this into my attention. The web UI is quite broken in master though, so I don't recommend using it right now.

itsgoingd commented 1 month ago

The web interface has been updated and old icons cleaned up in master (https://github.com/itsgoingd/clockwork/commit/806cc10b275e791ed6ab6c48ec30a0fcaeea2afb).