search

itsgoingd / clockwork

Clockwork - php dev tools in your browser - server-side component
https://underground.works/clockwork
MIT License
5.69k stars 321 forks source link

PHP 8.4: Missing`$escape` param for `fputcsv` and `str_getcsv` #718

Closed gharlan closed 1 month ago

gharlan commented 1 month ago

With the upcoming PHP 8.4 I get these deprecation notices:

fputcsv(): the $escape parameter must be provided as its default value will change Clockwork/Storage/FileStorage.php:306

str_getcsv(): the $escape parameter must be provided as its default value will change Clockwork/Storage/FileStorage.php:231

itsgoingd commented 1 month ago

Thanks, I'll fix it soon.

itsgoingd commented 1 month ago

Fixed in master now (https://github.com/itsgoingd/clockwork/pull/719), will release with Clockwork 5.3 before PHP 8.4 general availability.