search

itsharryle / LED_CUBE

8x8x8 LED cube powered by an arduino
MIT License
1.11k stars 382 forks source link

Added auto rotate functionality #10

Closed thexmanxyz closed 4 years ago

thexmanxyz commented 5 years ago

Actually I just wanted to answer the question asked in #8. But it would be great to have that functionality directly in the project if someone wants to tinker around so im creating this PR. It's just trivial but why not.

itsharryle commented 4 years ago

@thexmanxyz Hi! Thanks for adding this feature. If you could fix the error on line 85 pointed out by parasm0802 I would be more than happy to merge this PR in. Thanks for your contribution.

thexmanxyz commented 4 years ago

@parasm0802 Strangely I did not get a notification email for your comment. I completely missed that compile error. Will add a commit in the next minutes to fix that compilation error. Just wrote it without checking syntax I guess. @VectStudio. Sorry for that. You can merge it in the next minutes.

thexmanxyz commented 4 years ago

@VectStudio You are welcome! Sorry for adding a compilation error. I now verified the sketch and added another commit which adds the missing ) bracket. I'm curious why I did not get a notification mail on August 16th for the comment from @parasm0802 not even in my mail history. But whatever it is fixed now. Thanks in advance for merging!