search

itsjafer / schwab-api

A python library for placing trades on Charles Schwab
MIT License
201 stars 64 forks source link

Disable stealth options which block login iframe #64

Closed NelsonDane closed 1 month ago

NelsonDane commented 2 months ago

Fixes https://github.com/itsjafer/schwab-api/issues/63

On the main page, the iframe that was used for logging in was being blocked by the default stealth options. I went through each option and found the culprits and disabled them. This allows the iframe to show up while still keeping the other stealth options that allow logging in.

Would love a review, or if you have other thoughts, please let me know @itsjafer, but this fixes it for me.

yanowitz commented 1 month ago

this fixed the problem for me as well (though I have to use firefox as webkit is giving a ValueError: Only supported browserType is 'firefox' on my mac)

itsjafer commented 1 month ago

hi @NelsonDane, just checking in -- is this change still necessary?

NelsonDane commented 1 month ago

From my testing, I've found it is still necessary, and it has been working well for me and my users in my main project. It also seems to be the fix according to https://github.com/itsjafer/schwab-api/issues/63#issuecomment-2230067704, so I would welcome your thoughts/review :)