itsjunetime / smserver

An app to allow Jailbroken iPhones to send texts & attachments from their browser
GNU General Public License v3.0
157 stars 26 forks source link

Images sent with subject line text but no main body text don't show tapbacks | Images sent with both subject line text and main body text send with the text together instead of apart #110

Closed sabogalc closed 3 years ago

sabogalc commented 3 years ago

This issue is similar, but not the same as this BlueBubbles issue and this WebMessage issue. The main difference is that SMServer does show the text, it just doesn't show the text in the correct order, nor does it show any tapbacks.

Here are pictures from my Mac, iPhone, and SMServer client window. For the piñata picture - tapback_guid="p:0/C93C7CD5-9266-414B-BCC6-AD016E6A4D5D" For the "lose my mind" text - tapback_guid="p:1/C93C7CD5-9266-414B-BCC6-AD016E6A4D5D" Screen Shot 2021-03-18 at 3 55 54 PM PNG image SMServer p And then here is an example of an image sent with both subject line text and main body text For the slowness report picture - tapback_guid="p:0/EBF4C265-6DAE-4181-BF87-4C6E4DB19FBE" For the "Jason from homework" text - tapback_guid="p:1/EBF4C265-6DAE-4181-BF87-4C6E4DB19FBE" Screen Shot 2021-03-18 at 3 56 52 PM PNG image 1 SMServer J

EricRabil commented 3 years ago

Message subjects should be presented at the first part of the message, regardless of what that part is. In this case, if there is an image, a text chat item should precede the image with a subject and no main content.

itsjunetime commented 3 years ago

Alright, I found the issue and it looks like this should be fixed in the next version (don't worry, it should be coming out soon; I know it's been like months lol).

sabogalc commented 3 years ago

This is almost perfect. For some strange reason, SMServer added an extra space under my hello message. I'm not sure what could have caused this. Similar to my troll face sticker, the conversation history says that I applied a tapback to nothing Almost PNG Image PNG image (1) Some information about the messages.

"Hello" - tapback_guid="p:-1/1271A236-D9CF-457E-BA31-FB1D77FB2F95" " " - tapback_guid="p:0/1271A236-D9CF-457E-BA31-FB1D77FB2F95"

sabogalc commented 3 years ago

This issue has been fixed. The comment above is more inline with issue #124