itsjustcurtis / MenyooSP

[or Menyoo PC] - Trainer/mod menu for Grand Theft Auto V (single-player).
https://www.gta5-mods.com/scripts/menyoo-2-0
GNU General Public License v3.0
46 stars 8 forks source link

Please fix the makeup problem. They're all black and white for some reason. #29

Closed Arronovsky closed 8 months ago

Arronovsky commented 8 months ago

GTA5 2024-01-28 12-46-43

itsjustcurtis commented 8 months ago

I don't fully understand how the makeup should work. If you can elaborate on what you expect to see then I can investigate further.

TayMcKenzieNZ commented 8 months ago

Here's a database of how they're supposed to look. Hope this helps.

https://forge.plebmasters.de/decorations

On Mon, 29 Jan 2024, 12:45 am itsjustcurtis, @.***> wrote:

I don't fully understand how the makeup should work. If you can elaborate on what you expect to see then I can investigate further.

— Reply to this email directly, view it on GitHub https://github.com/itsjustcurtis/MenyooSP/issues/29#issuecomment-1913567956, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL3YMN5SSZ2VII22Z3D3DBTYQY26FAVCNFSM6AAAAABCN5IOVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGU3DOOJVGY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

itsjustcurtis commented 8 months ago

@TayMcKenzieNZ I didn't realise plebmasters had makeup as well. Thanks for sharing

itsjustcurtis commented 8 months ago

image

Appears to be functioning correctly. The default state of makeup is un-painted, and the primary and secondary colours need to be changed.

Arronovsky commented 8 months ago

In past versions, you didn't have to choose a primary and secondary color in your makeup. Here is an example from the picture. This is the texture of the makeup itself. There are several colors, and in the game it will not look like in the picture, because of the fact that you need to overlay colors. You know what I mean? makeup

Arronovsky commented 8 months ago

In version 1.7.5 makeup works properly. I attach a link, you can see the source code and just paste it into your trainer. https://github.com/MAFINS/MenyooSP/releases/tag/v1.7.5

itsjustcurtis commented 8 months ago

This is an intentional function added in commit 265 on the Mafins repo. The Feature is functioning as intended, reversing this change would remove the ability to select colour overlays.

Arronovsky commented 8 months ago

Is there any way to remove it?

itsjustcurtis commented 8 months ago

Only by regressing and reversing that change, which I do not intend to do. My objective is to improve and expand the functionality of Menyoo, not reduce it and undo the changes already made. If you have a suggestion on how this can be done without removing functionality, I am open to ideas.

TayMcKenzieNZ commented 8 months ago

Maybe if a makeup only has one set colour, then it defaults to that, but if it has multiple colour options then allow them? So like say a makeup colour is black by default, maybe Gray out the options?

On Mon, 29 Jan 2024, 10:36 am itsjustcurtis, @.***> wrote:

Only by regressing and reversing that change, which I do not intend to do. My objective is to improve and expand the functionality of Menyoo, not reduce it and undo the changes already made. If you have a suggestion on how this can be done without removing functionality, I am open to ideas.

— Reply to this email directly, view it on GitHub https://github.com/itsjustcurtis/MenyooSP/issues/29#issuecomment-1913729311, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL3YMN4UJT4XXUN3ULHC6M3YQ3AF7AVCNFSM6AAAAABCN5IOVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTG4ZDSMZRGE . You are receiving this because you were mentioned.Message ID: @.***>

itsjustcurtis commented 8 months ago

I'm currently investigating, from what I can tell the change was simply to tell the game that makeup can be colourable, there is zero reference to which ones can or can't be painted. I'm trying to see if there is a way I can set the "default" look which can later be changed.

Arronovsky commented 8 months ago

Have you looked at how the makeups are arranged in the 1.7.5 version?

Arronovsky commented 8 months ago

Please understand, makeup is a very important thing to many people. And the old version of the trainer do not want to use at all.

itsjustcurtis commented 8 months ago

I have, all that has been done is turned the ability to change colour on or off, that is all. I am currently working on a compromise, as being able to colour the makeup is also important. Please have patience.

Arronovsky commented 8 months ago

Okay, well, thank you for your efforts ❤️

Arronovsky commented 8 months ago

Why is being able to change the color of your makeup important? Just in the same GTA Online such a function is not. It seems to always use the texture of the original makeup

itsjustcurtis commented 8 months ago

Because if it wasn't, then the original change would never have been made. Just because you don't see it as important, doesn't mean others don't. I personally never use the ped stuff in menyoo, but I understand that you want to use it in a way different to me, so I am making it work.

itsjustcurtis commented 8 months ago

@Arronovsky please download the last pre-release (v2.0.1a4), this should fix your issue.

Arronovsky commented 8 months ago

@itsjustcurtis It's all working. Thank you so much! You are the best!