Vehicle Spawner: removed VehicleList.xml and added Open Wheel category

[katsutosh]

• added vehicle category Openwheel to Spawner
• added missing vehicles to VehicleList.xml (b3095)

[katsutosh]

good catch, didn't noticed it. Just checked it, the list is not necessary. Can we remove the code for reading the VehicleList.xml?

New PR for the OpenWheel category will be added later.

[itsjustcurtis]

if you make the edits and confirm it working in game, I can merge the PR if you add the commits to this

[metoxys]

I recommend renaming to "Open Wheel" and also adding a category for the drift cars added in the Chop Shop DLC

[katsutosh]

• removed VehicleList.xml stuff
• each vehicleclass has it's own category in spawnmenu

All changes are working ingame.

(the driftcars are in the same category as the non-drift version)

[metoxys]

(the driftcars are in the same category as the non-drift version)

Consider hardcoding the model names into a separate Drift category

[itsjustcurtis]

I'm not a fan of hard-coding and would have preferred not moving the drift cars to their own category, however with R*s insistence on making them the same vehicle with a different handling, I'm not sure how we can easily differentiate the drift variants.

It may be worth (in the future) adding a "drift conversion" function to those with that availability to menyoo customs. For now this is okay, merging.

[metoxys]

(commenting here because this fork has no Issue or Discussion area)
@itsjustcurtis Consider the fact that the drift cars literally have their own model and handling IDs. For instance, drifttampa is the Drift Tampa with drift tuning whereas tampa2 is the Drift Tampa that was added years ago.

[itsjustcurtis]

Consider the fact that the drift cars literally have their own model and handling IDs.

This is precisely why I've accepted the PR tbh, I can't think of a better way for now without having the drift conversion, which in and of itself would need to be hard-coded

[metoxys]

Consider the fact that the drift cars literally have their own model and handling IDs.

This is precisely why I've accepted the PR tbh, I can't think of a better way for now without having the drift conversion, which in and of itself would need to be hard-coded

Well, presumably, GTAO handles the "drift conversion" by just changing the model of the car the player is in while keeping the data about modifications. But that just moves the hardcoding to another place, namely the list of cars that can be drift-converted, and the mapping between the drift and non-drift cars.
In my opinion, the least intrusive method is a separate "Drift" category in the spawner

[SkyK0T]

The menu does not see most of the transport models, maybe you should not have deleted the list? And as for me it is more convenient when you can add to the file as a separate list, and you can categorize yourself) on the contrary, I would like to see additional lists, such as a list of effects and so on. yeah normal in-game names wouldn't hurt either) It would also be nice to sort by add-on number

[katsutosh]

The menu does not see most of the transport models

Which vehicles do you mean by transport models? I checked all categories and the list looked complete for me

[itsjustcurtis]

The menu does not see most of the transport models, maybe you should not have deleted the list? And as for me it is more convenient when you can add to the file as a separate list, and you can categorize yourself) on the contrary, I would like to see additional lists, such as a list of effects and so on. yeah normal in-game names wouldn't hurt either) It would also be nice to sort by add-on number

Can you raise an issue and be more specific when you do please. I agree that being able to categorise yourself may have been a useful feature, though I personally never used it, that may have been the original intent behind the list.

[SkyK0T]

I use the cheat for online and its downloader asi there are conflicts, did not see the list of add-ons) all with the list is fine I stupil) can I throw you a few improvements?, I did for myself, but the cheat as if for all you finalize, and with open source and not like that upstart who complained I now on the last account gave restrictions

[itsjustcurtis]

@SkyK0T as I say, either raise suggestions in the Issues tab or send as a PR to this repository and I can review. Anything that is designed to modify GTAO content or gameplay however will be rejected as that violates TOS

[SkyK0T]

pulrequests don't work here( I'll throw some of them here, and rockstar doesn't care about asi files for a long time already, there are much more powerful cheats.

[SkyK0T]

Full PedList 1.68 reorganized PedList.zip

[itsjustcurtis]

pulrequests don't work here( I'll throw some of them here, and rockstar doesn't care about asi files for a long time already, there are much more powerful cheats.

You are commenting on a pull request. I assure you they work. You need to fork from this repo to then PR back into it. Being honest though, such a flagrant disregard for the TOS is not something I really want involved in this project, regardless if R* will actually do anything about it. My integrity as a programmer does not want to violate that.