itsjustcurtis / MenyooSP

[or Menyoo PC] - Trainer/mod menu for Grand Theft Auto V (single-player).
https://www.gta5-mods.com/scripts/menyoo-2-0
GNU General Public License v3.0
36 stars 7 forks source link

Ped Variation crashes on certain models #49

Open itsjustcurtis opened 5 months ago

itsjustcurtis commented 5 months ago

image

itsjustcurtis commented 5 months ago

the -1 variant is effectively a "null" value, loading nothing when used; appears to work as expected for the most part, but on some peds there is the possibility of this crashing the game. I am unsure if I'm able to differentiate which ones crash and which ones wont, so its a case of either live with this as a known bug, or remove the option for null entirely.

Eunice1191 commented 5 months ago

I wouldn't remove null entirely. Most peds seem to be just fine going to null. And if you want a spawn a ped with no legs for example, the only way to do it is to put Legs to -1, thus making them disappear. This also works great on some addon peds where you can remove various components for roleplay. etc. The only time I noticed crashing is when going to -1 on main characters (Franklin, Michael, Trevor) particularly in the Head slot. Other slots seem to work going to -1.

So I don't know if there is some sort of a safe guard that can be implemented for other peds based on the error thrown by the main characters when going to -1 on Head.

itsjustcurtis commented 5 months ago

I thought that might be the case. There doesn't seem to be a reliable pattern of which ones will cause a crash or not that I can see, and as the game doesn't report errors, so I can't really use that either.

I'll put the code in a try;catch; module and see if that prevents anything, but I may just need an on-screen warning, or even have an ini option to allow users to explicitly turn it on knowing the risks.

itsjustcurtis commented 5 months ago

Looks like try/catch only works to prevent menyoo from crashing; the actual command appears to crash the game before the script has even processed any errors. I may need to simply warn users when using ped variations.

Eunice1191 commented 5 months ago

For the peds known to have the issue 100%, can it be hard-coded to prevent their wardrobe slot going to null? Ie we know changing Michael's Head to -1 will cause a crash. So hardcode it that if the ped is Michael, you can't change Head to -1.

Would require a lot of manual checking though on all the peds. But based on my experience, 90% of peds are fine.

TayMcKenzieNZ commented 5 months ago

The only peds that seem affected by this issue are Michael, Trevor and Franklin's head components. You can remove their body and it'll glitch out but won't cause any crashes.

I think hard coding them to be grayed out would probably work wonders, but I'm curious as to what Eclipse thinks about this all as he was the one who brought it up on GTA5Mods. 🤔

itsjustcurtis commented 5 months ago

See I've had the opposite experience, works fine for the protag models, and fails on others.

I'm trying to remove hardcoding where possible from menyoo to future proof it, I don't really want to be adding my own. Not only that but the sheer volume of permutations that list could have is massive; the hardcoded list needed would be huge.

SkyK0T commented 5 months ago

Think better about global problems), there are about a thousand passersby in the game, for each search and put a blocking? I certainly know almost all the crashpeds, for Michael for example 7 head, in addition to -1 many private online cheats still can not fix it, in this regard, random clothing for models can apply incorrect object, I think in general this option is not necessary, random clothing at your own risk, no well if you want to prescribe blocking every passerby, do it

itsjustcurtis commented 5 months ago

Think better about global problems), there are about a thousand passersby in the game, for each search and put a blocking? I certainly know almost all the crashpeds, for Michael for example 7 head, in addition to -1 many private online cheats still can not fix it, in this regard, random clothing for models can apply incorrect object, I think in general this option is not necessary, random clothing at your own risk, no well if you want to prescribe blocking every passerby, do it

I think you might be misunderstanding the issue we're discussing. This is exclusively talking about customisation of a specific ped the player is using, not every pure in the world; as you say, that would be an unreasonable ask for the game.

SkyK0T commented 5 months ago

Think better about global problems), there are about a thousand passersby in the game, for each search and put a blocking? I certainly know almost all the crashpeds, for Michael for example 7 head, in addition to -1 many private online cheats still can not fix it, in this regard, random clothing for models can apply incorrect object, I think in general this option is not necessary, random clothing at your own risk, no well if you want to prescribe blocking every passerby, do it

I think you might be misunderstanding the issue we're discussing. This is exclusively talking about customisation of a specific ped the player is using, not every pure in the world; as you say, yay would be an unfashionable ask for the game.

Well create an anti-crash then, as in private online cheats that it blocks invalid component, good luck,PS Comment do not delete more ok? Here most of it is needed for FIVEM where custom models of passersby are used. It's not a bug, and it's not a problem.

itsjustcurtis commented 5 months ago

Think better about global problems), there are about a thousand passersby in the game, for each search and put a blocking? I certainly know almost all the crashpeds, for Michael for example 7 head, in addition to -1 many private online cheats still can not fix it, in this regard, random clothing for models can apply incorrect object, I think in general this option is not necessary, random clothing at your own risk, no well if you want to prescribe blocking every passerby, do it

I think you might be misunderstanding the issue we're discussing. This is exclusively talking about customisation of a specific ped the player is using, not every pure in the world; as you say, yay would be an unfashionable ask for the game.

Well create an anti-crash then, as in private online cheats that it blocks invalid component, good luck,PS Comment do not delete more ok? Here most of it is needed for FIVEM where custom models of passersby are used. It's not a bug, and it's not a problem.

Again, I think you've misunderstood.

I'll put the code in a try;catch; module and see if that prevents anything, but I may just need an on-screen warning, or even have an ini option to allow users to explicitly turn it on knowing the risks.

This segment was talking about some crash-prevention. If you know of a method where I can intercept and prevent crashes before they happen, please do share.