itsjustcurtis / MenyooSP

[or Menyoo PC] - Trainer/mod menu for Grand Theft Auto V (single-player).
https://www.gta5-mods.com/scripts/menyoo-2-0
GNU General Public License v3.0
36 stars 7 forks source link

Incorrect saving of character's face from multiplayer, or director mode does not recognize facial outlines #53

Open SkyK0T opened 5 months ago

SkyK0T commented 5 months ago

Incorrect saving of character's face from multiplayer, or director mode does not recognize facial outlines I think it's because of the parameter Static_241 == PLAYER_PED_ID(); 241 is written everywhere. instead of Static_240 = PLAYER_ID network player but I'm not sure, At the same time father and mother are recognized correctly I want to do this for a long time, but I do not understand what parameters need to be changed, the character created from the menu saves correctly, maybe it will work through a clone.

That's how it is in the original

image image

Menyoo image image

itsjustcurtis commented 5 months ago

Looking at your screenshots, it appears that it's simply a case of the mother and father features are being inverted. If that is the case then this should be a relatively straightforward fix

SkyK0T commented 5 months ago

this is not the only thing> does not recognize PED_HEAD_BLENDDATA and facial features like nose, jaw width and so on are all set to 0. and SET​PED​MICRO​MORPH When you create a character in the menu itself, and its loading all the parameters are correct, but from the mode of the director does not recognize https://nativedb.dotindustries.dev/gta5/natives/0x71A5C1DBA060049E?search=MORPH

SkyK0T commented 5 months ago

Note the problem https://github.com/MAFINS/MenyooSP/issues/625#issue-1960180501 https://wiki.rage.mp/index.php?title=Player::setHeadBlend I gave a correction, but you deleted it again. Shape / Skin First ID: "Mother" Shape / Skin Second ID: "Father"

itsjustcurtis commented 5 months ago

Apologies, your "original" screenshot had all zeroes so it wasn't clear that wasn't working.

I'll look into the blend, I recall seeing it in the code, so hopefully it's not too big a deal.

For the record, I haven't deleted anything here; if I do, you'll see a note in the history that I've deleted something.

itsjustcurtis commented 5 months ago

@SkyK0T can I check which version of Menyoo you are using?

image

This is what the current state should look like, and as far as I can tell, this menu has never changed since the MAFINS original commit 5 years ago, so am not sure how you are seeing what you are

SkyK0T commented 5 months ago

on any version, now on your as an example, I wrote above it does not recognize the contour of the face, nose, lips, chin, and makeup too, like blush and beard from a character who is online in director mode) and so on, on my screenshots above you can see that the head of the mother and father he sees (what I wrote originally), the contours of the face does not recognize, that's the problem, and you can not create a character online and save it in the cheat ### MP random Model image image

**###

Menyoo save model

** image image

itsjustcurtis commented 5 months ago

Can you provide steps to replicate for me please. I'm struggling to fully understand the issue in its entirety. If you can provide steps for me to replicate it then I may get a better understanding of what is happening

SkyK0T commented 5 months ago

Can you provide steps to replicate for me please. I'm struggling to fully understand the issue in its entirety. If you can provide steps for me to replicate it then I may get a better understanding of what is happening

Can't you see the difference in face? Or is it the same face?

SkyK0T commented 5 months ago

I write in every way that facial features are not preserved, what's hard to understand that?

itsjustcurtis commented 5 months ago

I'm not disputing that, I can see that, however your screenshots are showing that the values being used are the same, which shouldn't be possible.

I just want the steps you've taken to get to this point so I can replicate it and better understand what it is actually doing, and put debugging in that area of the code.

This isn't me misunderstanding you, this is me misunderstanding what on earth Menyoo is trying to do here, please don't take my questions as a slight against you, as I assure you they're not, this is a normal part of debugging complex problems.

itsjustcurtis commented 5 months ago

If you can DM me on discord then we can have a productive conversation and I can send over test versions whilst I change things and investigate. Would male this whole process a lot easier :)

itsjustcurtis commented 5 months ago

Hi @SkyK0T I've only just been able to test this in-game, and I'm unable to replicate using what I think is the method you're using. I'm creating characters in the menu, saving them via the outfits menu and recalling them without issue. I'm going to close this issue for now as I can't see an problem. If you can give me more specifics on what you're doing to see the issue, then I'll be happy to reopen.

SkyK0T commented 5 months ago

Hi @SkyK0T I've only just been able to test this in-game, and I'm unable to replicate using what I think is the method you're using. I'm creating characters in the menu, saving them via the outfits menu and recalling them without issue. I'm going to close this issue for now as I can't see an problem. If you can give me more specifics on what you're doing to see the issue, then I'll be happy to reopen.

WHAT is unclear in the phrase that the menu doesn't recognize facial features, multiplayer characters from director mode (models from online) and saves them incorrectly???? I've given a thousand examples and explanations of even what may need to be done, if you can not understand the elementary, then where do you understand the problem?

itsjustcurtis commented 5 months ago

What is unclear in the phrase I have tested this and am unable to replicate? Please help me help you, your increased hostility is not particularly useful when I am trying to ask for your assistance. Unfortunately I do not know or use every aspect of the game, so there are naturally areas that I am not familiar with; If you can help me in the way I've requested, then I can look into it in more detail.

itsjustcurtis commented 1 day ago

From @SkyK0T

[Пять дней] Я пытаюсь сохранить свой mp_f_freemode_01 ped с чертами лица, но это не сохраняется вообще. Форму и оттенок он сохраняет, но цвета FacialFeatures и Overlays - нет. Можно ли исправить и сохранить эти значения в XML-файл?

[FiveM] I'm trying to save my mp_f_freemode_01 ped with facial features but it doesn't save at all. The ShapeAndSkinTone it does save but the FacialFeatures and Overlays colours doesn't. Is possible to be fixed and save those values to XML file?

the problem is that the menu does not see the facial feature of the network player, and sees if created in the menu itself, the editor does not work correctly, it sees it as a passerby (Static_241 = PLAYER_PED_ID() as a network player 240, and the author is afraid of the courts rockstar )) and nothing to do with online does not want to do))) joke, I think you need to dig into the nativas, I already offered help, I was not understood, or did not want to understand now I'm just an observer, I do not know how to do it, but it's my long-time dream to save faces, I'm quietly doing my own version, for example, I sorted passersby by add-ons, and I did it at the beginning of the year, and not like you fixed a player a week ago) let's do it this way, you try to fix the face, and I'll give you my work with fixes and stuff, but in general I don't really see you fixing/adding features, you're doing nonsense like logs that are needed by developers and not by users.

https://github.com/Jerrrry123/JerryScript this is the creator of the lua script for the stand, has already realized something similar. https://github.com/Jerrrry123/JerryScript/blob/main/JerryScript.lua starting on line 1636

Thanks for this, I'll prioritise the ped outfit issue as I did notice that one was there but doing weird stuff. The way Menyoo implemented the facial customisation was a touch confusing to me; what you've shared here is really useful to try and understand a bit better how it works (I am a bit rusty with lua, but I can just about make sense of what its doing)

itsjustcurtis commented 1 day ago

Having checked some of my own save files, it appears that the issue is in the saving of items, as the xml shows all zeroes against the facial data. I have added some new debug logging to better ascertain what the code is doing when saving but will be unable to test until scripthook is back up.

In the meantime, @SkyK0T can you double check your own save files and confirm you're also seeing zeros in the facialfeatures section, and its not just me having not edited the faces of my saved peds!