itskalvik / ST-GCN

Unofficial Tensorflow implementation of the AAAI'18 paper "Spatial Temporal Graph Convolutional Networks for Skeleton-Based Action Recognition"
66 stars 13 forks source link

Some questions about your code and using the Kinetics-skeleton dataset #5

Closed zhang197 closed 1 year ago

zhang197 commented 3 years ago

Hello, Thank you very much for sharing the code based on tensorflow framework ! I have some questions to ask you for advice.

if edge_importance_weighting: self.edge_importance = nn.ParameterList([ nn.Parameter(torch.ones(self.A.size())) for i in self.st_gcn_networks ]) I've noticed that you don't seem to use mask in your code. Am I correct?

Do you know the reason or can you give me some advice.

itskalvik commented 3 years ago

Yes, I don't have a separate mask. You can look into my other repo here to implement a few other GCNs; some of the models in that repo have such masks.

It's been a while since I implemented this; I believe I got better results with BatchNorm instead of Dropout for regularization.

Finally, yes, I had the same issue with the Kinetics dataset; I wasn't sure what the issue was and decided to skip it. Perhaps double-check the results with the original implementation and see if all the model hyperparameters match.

zhang197 commented 3 years ago

Thank you very much for your reply!:) I will reconfirm whether the hyperparameters parameters match